admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Henrik Boström fe25b0e928 Report 'outbound-rtp.targetBitrate' correctly and per-RTP stream. 
This CL fixes two issues with the old way targetBitrate was reported:
1. The target is per encoder, i.e. per SSRC, but the old way to report
   it was per sender and was approximately the sum of all encodings'
   targetBitrate in most cases.
2. The old value did not come directly from the VideoBitrateAllocation
   and tended to be greater than the sum of all targets (don't know
   why).

We know the old value was wrong and the new value correct because
the actual bytes produced by the encoder closely matches the configured
target, which wasn't always the case with the old metric implementation.

Tested with unit tests and manually in Chrome by going to
https://henbos.github.io/codec-quality/src/index.html and ensuring
target ~= actual bytes produced. It also matches the debug logging of
video_stream_encoder.cc.

Bug: webrtc:42225524, chromium:392424845
Change-Id: I7a6f69e053ebc3fd972c2c4b7712750e721c0acc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/376460
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43854}
2025-02-06 09:55:11 -08:00
..
g3doc
doc: remove mention of SDES srtp_filter
2024-12-16 14:40:01 -08:00
scenario_tests
Reland "Replace usage of link_capacity_kbps with DataRate link_capacity"
2024-05-16 10:39:10 +00:00
test
Restructure PeerConnection tests not to create PortAllocator directly
2025-02-05 04:08:12 -08:00
audio_rtp_receiver_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
audio_rtp_receiver.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
audio_rtp_receiver.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
audio_track.cc
…
audio_track.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
BUILD.gn
Restructure PeerConnection tests not to create PortAllocator directly
2025-02-05 04:08:12 -08:00
channel_interface.h
Add RtpSender OnFirstPacketSent callback.
2024-10-25 16:17:04 +00:00
channel_unittest.cc
Format /pc folder
2025-01-08 11:55:45 -08:00
channel.cc
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
channel.h
Add RtpSender OnFirstPacketSent callback.
2024-10-25 16:17:04 +00:00
codec_vendor_unittest.cc
Move a test from media_session_unittest to codec_vendor_unittest
2025-01-28 01:44:01 -08:00
codec_vendor.cc
Refactor media_session to move codec handling to new class
2025-01-27 07:52:12 -08:00
codec_vendor.h
Refactor media_session to move codec handling to new class
2025-01-27 07:52:12 -08:00
congestion_control_integrationtest.cc
Slight restriction of access to ContentInfo and prefer mid to name.
2025-01-17 06:19:38 -08:00
connection_context.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
connection_context.h
Deprecate rtc::RefCountInterface
2024-06-07 09:47:26 +00:00
data_channel_controller_unittest.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
data_channel_controller.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
data_channel_controller.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
data_channel_integrationtest.cc
DTLS 1.3 - patch 5
2025-01-28 03:15:36 -08:00
data_channel_unittest.cc
Start deprecation process for non-Optional datachannel parameters
2025-01-22 04:10:16 -08:00
data_channel_utils.cc
…
data_channel_utils.h
…
DEPS
Remove srtpfilter_unittest rule from DEPS
2024-12-09 17:34:59 +00:00
dtls_srtp_transport_integrationtest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
dtls_srtp_transport_unittest.cc
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
dtls_srtp_transport.cc
Let ZeroOnFreeBuffer do the memcpy for DTLS-SRTP key extraction
2024-10-18 11:18:21 +00:00
dtls_srtp_transport.h
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
dtls_transport_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
dtls_transport.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
dtls_transport.h
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
dtmf_sender_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
dtmf_sender.cc
…
dtmf_sender.h
…
external_hmac.cc
…
external_hmac.h
Remove private SRTP include
2024-07-23 17:23:45 +00:00
ice_server_parsing_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
ice_server_parsing.cc
Remove deprecated ParseIceServers variant
2024-10-01 15:28:06 +00:00
ice_server_parsing.h
Remove deprecated ParseIceServers variant
2024-10-01 15:28:06 +00:00
ice_transport_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
ice_transport.cc
…
ice_transport.h
…
jitter_buffer_delay_unittest.cc
…
jitter_buffer_delay.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
jitter_buffer_delay.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
jsep_ice_candidate.cc
…
jsep_session_description_unittest.cc
Split "helpers" from SSL target to "crypto_random" and rename
2024-06-07 06:41:51 +00:00
jsep_session_description.cc
Make mid_ a private member variable
2025-01-23 00:53:11 -08:00
jsep_transport_collection.cc
Reland "Add PT lookup function to JsepTransportController"
2024-08-26 17:24:15 +00:00
jsep_transport_collection.h
…
jsep_transport_controller_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
jsep_transport_controller.cc
Slight restriction of access to ContentInfo and prefer mid to name.
2025-01-17 06:19:38 -08:00
jsep_transport_controller.h
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
jsep_transport_unittest.cc
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
jsep_transport.cc
Guard against redefining a PT within a single codec list.
2024-10-28 12:16:13 +00:00
jsep_transport.h
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
legacy_stats_collector_interface.h
…
legacy_stats_collector_unittest.cc
Unify TLS cipher suite name handling
2024-09-27 21:45:18 +00:00
legacy_stats_collector.cc
Unify TLS cipher suite name handling
2024-09-27 21:45:18 +00:00
legacy_stats_collector.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
local_audio_source_unittest.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
local_audio_source.cc
…
local_audio_source.h
…
media_factory.h
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
media_options.cc
Refactor media_session to move codec handling to new class
2025-01-27 07:52:12 -08:00
media_options.h
Refactor media_session to move codec handling to new class
2025-01-27 07:52:12 -08:00
media_protocol_names.cc
…
media_protocol_names.h
…
media_session_unittest.cc
Move a test from media_session_unittest to codec_vendor_unittest
2025-01-28 01:44:01 -08:00
media_session.cc
red: remove hardcoded parameters in favor of taking them from the codec
2025-02-04 10:28:30 -08:00
media_session.h
Refactor media_session to move codec handling to new class
2025-01-27 07:52:12 -08:00
media_stream_observer.cc
…
media_stream_observer.h
…
media_stream_proxy.h
…
media_stream_track_proxy.h
…
media_stream_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
media_stream.cc
…
media_stream.h
…
OWNERS
Remove orphis from OWNERS files
2024-12-03 15:00:21 +00:00
peer_connection_adaptation_integrationtest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
peer_connection_bundle_unittest.cc
Expose direct access to PeerConnection in PeerConnectionWrapper helper
2025-02-04 10:46:11 -08:00
peer_connection_crypto_unittest.cc
Replace use of .name in test code with .mid()
2025-01-21 10:25:53 -08:00
peer_connection_data_channel_unittest.cc
Expose direct access to PeerConnection in PeerConnectionWrapper helper
2025-02-04 10:46:11 -08:00
peer_connection_encodings_integrationtest.cc
Make IsSameRtpCodecIgnoringLevel work for any codec.
2025-01-24 05:37:17 -08:00
peer_connection_end_to_end_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
peer_connection_factory_proxy.h
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
peer_connection_factory_unittest.cc
Format /pc folder
2025-01-08 11:55:45 -08:00
peer_connection_factory.cc
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
peer_connection_factory.h
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
peer_connection_field_trial_tests.cc
Format /pc folder
2025-01-08 11:55:45 -08:00
peer_connection_header_extension_unittest.cc
Refactor PC tests to use non-global field trials
2024-12-16 05:29:01 -08:00
peer_connection_histogram_unittest.cc
Restructure PeerConnection tests not to create PortAllocator directly
2025-02-05 04:08:12 -08:00
peer_connection_ice_unittest.cc
Restructure PeerConnection tests not to create PortAllocator directly
2025-02-05 04:08:12 -08:00
peer_connection_integrationtest.cc
Restructure PeerConnection tests not to create PortAllocator directly
2025-02-05 04:08:12 -08:00
peer_connection_interface_unittest.cc
Replace use of .name in test code with .mid()
2025-01-21 10:25:53 -08:00
peer_connection_internal.h
Update PeerConnectionSdpMethods::AddRemoteCandidate
2025-01-21 08:24:22 -08:00
peer_connection_jsep_unittest.cc
Replace use of .name in test code with .mid()
2025-01-21 10:25:53 -08:00
peer_connection_media_unittest.cc
Add unidirectional codec support ("offer to send" use case).
2025-01-22 08:27:25 -08:00
peer_connection_message_handler.cc
…
peer_connection_message_handler.h
…
peer_connection_proxy.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
peer_connection_rampup_tests.cc
Restructure PeerConnection tests not to create PortAllocator directly
2025-02-05 04:08:12 -08:00
peer_connection_rtp_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
peer_connection_signaling_unittest.cc
Expose direct access to PeerConnection in PeerConnectionWrapper helper
2025-02-04 10:46:11 -08:00
peer_connection_simulcast_unittest.cc
Remove more sstream deps
2024-07-09 10:30:26 +00:00
peer_connection_svc_integrationtest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
peer_connection_wrapper.cc
Expose direct access to PeerConnection in PeerConnectionWrapper helper
2025-02-04 10:46:11 -08:00
peer_connection_wrapper.h
Expose direct access to PeerConnection in PeerConnectionWrapper helper
2025-02-04 10:46:11 -08:00
peer_connection.cc
Update PeerConnectionSdpMethods::AddRemoteCandidate
2025-01-21 08:24:22 -08:00
peer_connection.h
Update PeerConnectionSdpMethods::AddRemoteCandidate
2025-01-21 08:24:22 -08:00
proxy_unittest.cc
Deprecate rtc::RefCountInterface
2024-06-07 09:47:26 +00:00
proxy.h
Apply include-cleaner to api direct files
2024-09-10 08:29:26 +00:00
remote_audio_source.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
remote_audio_source.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
rtc_stats_collector_unittest.cc
Report 'outbound-rtp.targetBitrate' correctly and per-RTP stream.
2025-02-06 09:55:11 -08:00
rtc_stats_collector.cc
Report 'outbound-rtp.targetBitrate' correctly and per-RTP stream.
2025-02-06 09:55:11 -08:00
rtc_stats_collector.h
Use environment monotonic timestamps (i.e. not UTC) in RTCStats.
2024-10-03 09:07:17 +00:00
rtc_stats_integrationtest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
rtc_stats_traversal_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
rtc_stats_traversal.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
rtc_stats_traversal.h
…
rtcp_mux_filter_unittest.cc
…
rtcp_mux_filter.cc
…
rtcp_mux_filter.h
…
rtp_media_utils_unittest.cc
…
rtp_media_utils.cc
…
rtp_media_utils.h
Remove <ostream> dependencies
2024-07-03 12:27:55 +00:00
rtp_parameters_conversion_unittest.cc
Remove functions from rtp_parameters_conversion.
2024-10-30 11:28:11 +00:00
rtp_parameters_conversion.cc
Remove an unused conversion function.
2024-11-20 13:06:08 +00:00
rtp_parameters_conversion.h
Remove functions from rtp_parameters_conversion.
2024-10-30 11:28:11 +00:00
rtp_receiver_proxy.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
rtp_receiver.cc
Reland "Run IWYU on some files I intend to work on"
2024-06-05 08:59:49 +00:00
rtp_receiver.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
rtp_sender_proxy.h
Add RtpSender OnFirstPacketSent callback.
2024-10-25 16:17:04 +00:00
rtp_sender_receiver_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
rtp_sender.cc
Add RtpSender OnFirstPacketSent callback.
2024-10-25 16:17:04 +00:00
rtp_sender.h
Add RtpSender OnFirstPacketSent callback.
2024-10-25 16:17:04 +00:00
rtp_transceiver_unittest.cc
Make IsSameRtpCodecIgnoringLevel work for any codec.
2025-01-24 05:37:17 -08:00
rtp_transceiver.cc
Add unidirectional codec support ("offer to send" use case).
2025-01-22 08:27:25 -08:00
rtp_transceiver.h
Add unidirectional codec support ("offer to send" use case).
2025-01-22 08:27:25 -08:00
rtp_transmission_manager.cc
Propagate environment to RtpSenders
2024-09-03 11:56:22 +00:00
rtp_transmission_manager.h
Propagate environment to RtpSenders
2024-09-03 11:56:22 +00:00
rtp_transport_internal.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
rtp_transport_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
rtp_transport.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
rtp_transport.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
sctp_data_channel.cc
Start deprecation process for non-Optional datachannel parameters
2025-01-22 04:10:16 -08:00
sctp_data_channel.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
sctp_transport_unittest.cc
Replace gunit.h macros with WaitUntil in pc/
2025-01-08 05:34:50 -08:00
sctp_transport.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
sctp_transport.h
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
sctp_utils_unittest.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
sctp_utils.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
sctp_utils.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
sdp_munging_detector.cc
Replace use of .name in test code with .mid()
2025-01-21 10:25:53 -08:00
sdp_munging_detector.h
Measure SDP munging
2025-01-15 07:38:45 -08:00
sdp_offer_answer_unittest.cc
Restore primary/rtx payload type assignment logic
2025-01-31 06:41:50 -08:00
sdp_offer_answer.cc
Make mid_ a private member variable
2025-01-23 00:53:11 -08:00
sdp_offer_answer.h
Measure SDP munging
2025-01-15 07:38:45 -08:00
sdp_state_provider.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
sdp_utils.cc
Replace use of .name in test code with .mid()
2025-01-21 10:25:53 -08:00
sdp_utils.h
…
session_description_unittest.cc
…
session_description.cc
Make mid_ a private member variable
2025-01-23 00:53:11 -08:00
session_description.h
Make mid_ a private member variable
2025-01-23 00:53:11 -08:00
simulcast_description.cc
…
simulcast_description.h
…
simulcast_sdp_serializer_unittest.cc
Rename simulcast SDP serializer
2023-09-18 10:09:02 +00:00
simulcast_sdp_serializer.cc
Avoid string duplication when returning StringBuilder strings
2024-10-23 07:54:18 +00:00
simulcast_sdp_serializer.h
Rename simulcast SDP serializer
2023-09-18 10:09:02 +00:00
slow_peer_connection_integration_test.cc
Restructure PeerConnection tests not to create PortAllocator directly
2025-02-05 04:08:12 -08:00
srtp_session_unittest.cc
srtp: stop using private libsrtp function to determine packet index
2025-01-26 22:10:27 -08:00
srtp_session.cc
srtp: stop using private libsrtp function to determine packet index
2025-01-26 22:10:27 -08:00
srtp_session.h
Reland "srtp: spanify Protect + Unprotect"
2025-01-24 11:40:56 -08:00
srtp_transport_unittest.cc
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
srtp_transport.cc
Reland "srtp: spanify Protect + Unprotect"
2025-01-24 11:40:56 -08:00
srtp_transport.h
Reland "srtp: spanify Protect + Unprotect"
2025-01-24 11:40:56 -08:00
stream_collection.h
…
track_media_info_map_unittest.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
track_media_info_map.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
track_media_info_map.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
transceiver_list.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
transceiver_list.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
transport_stats.cc
…
transport_stats.h
Move DTLS related code from p2p/base to p2p/dtls
2024-12-10 15:55:26 +00:00
usage_pattern.cc
Report all usage patterns to UKM
2024-11-22 11:13:47 +00:00
usage_pattern.h
…
used_ids_unittest.cc
Dynamically assign ids to header extensions not enabled by default
2024-02-08 12:52:58 +00:00
used_ids.h
Revert "Reland "Use Payload Type suggester for all codec merging""
2025-01-17 23:49:26 -08:00
video_rtp_receiver_unittest.cc
Remove not-needed webrtc:: prefixes in pc/
2023-11-13 13:23:04 +00:00
video_rtp_receiver.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
video_rtp_receiver.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
video_rtp_track_source_unittest.cc
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
video_rtp_track_source.cc
…
video_rtp_track_source.h
…
video_track_source_proxy.cc
…
video_track_source_proxy.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
video_track_source.cc
…
video_track_source.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
video_track_unittest.cc
…
video_track.cc
…
video_track.h
Migrate absl::optional to std::optional
2024-09-02 12:16:47 +00:00
webrtc_sdp_unittest.cc
Replace use of .name in test code with .mid()
2025-01-21 10:25:53 -08:00
webrtc_sdp.cc
Replace use of .name in test code with .mid()
2025-01-21 10:25:53 -08:00
webrtc_sdp.h
Break out parsing of FMTP lines so that others can use it
2024-05-16 10:22:23 +00:00
webrtc_session_description_factory.cc
Add payload type assignment to offer/answer generation.
2024-09-17 12:31:25 +00:00
webrtc_session_description_factory.h
Add payload type assignment to offer/answer generation.
2024-09-17 12:31:25 +00:00