78c73477c7
Enumerating windows owned by the current process on Windows has some complications due to the GetWindowText*() APIs potentially causing a deadlock. The APIs will send messages to the window's message loop, and if the message loop is waiting on this operation we will enter a deadlock. I previously put in a mitigation for this [1] which brought the incidence rate down by an order of magnitude, but we are still seeing this issue fairly frequently. So, I've added DesktopCaptureOption enumerate_current_process_windows which allows consumers to avoid this issue completely by ignoring these potentially problematic windows. By default the flag is set to true which equates with the current behavior, consumers can set the flag to false to get the new behavior. I've also updated all the capturers that enumerate windows on Windows to respect the option. [1] https://webrtc-review.googlesource.com/c/src/+/195365 Bug: chromium:1152841 Change-Id: I0e0d868957d6fbe1e607a440b3a909d005c93ccf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219380 Commit-Queue: Austin Orion <auorion@microsoft.com> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#34191}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs