We currently use raw jobject in our code mixed with sporadic ScopedLocalRefFrame. This CL moves every jobject into a scoped object, either local, global, or a parameter. Also, this CL uses the JNI generation script to generate declaration stubs for the Java->C++ functions so that it no longer becomes possible to mistype them without getting compilation errors. TBR=brandt@webrtc.org Bug: webrtc:8278,webrtc:6969 Change-Id: Ic7bac74a89c11180177d65041086d7db1cdfb516 Reviewed-on: https://webrtc-review.googlesource.com/34655 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21387}
49 lines
1.7 KiB
Java
49 lines
1.7 KiB
Java
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
package org.webrtc;
|
|
|
|
/** Factory for instantiating the default webrtc::AudioProcessing implementation. */
|
|
@JNINamespace("webrtc::jni")
|
|
public class DefaultAudioProcessingFactory implements AudioProcessingFactory {
|
|
public DefaultAudioProcessingFactory() {
|
|
this(null /* postProcessingFactory */);
|
|
}
|
|
|
|
/**
|
|
* Allows injecting a PostProcessingFactory. A null PostProcessingFactory creates a
|
|
* webrtc::AudioProcessing with nullptr webrtc::postProcessing.
|
|
*/
|
|
public DefaultAudioProcessingFactory(PostProcessingFactory postProcessingFactory) {
|
|
this.postProcessingFactory = postProcessingFactory;
|
|
}
|
|
|
|
/**
|
|
* Creates a default webrtc::AudioProcessing module, which takes ownership of objects created by
|
|
* its factories.
|
|
*/
|
|
@Override
|
|
public long createNative() {
|
|
long nativePostProcessor = 0;
|
|
if (postProcessingFactory != null) {
|
|
nativePostProcessor = postProcessingFactory.createNative();
|
|
if (nativePostProcessor == 0) {
|
|
throw new NullPointerException(
|
|
"PostProcessingFactory.createNative() may not return 0 (nullptr).");
|
|
}
|
|
}
|
|
return nativeCreateAudioProcessing(nativePostProcessor);
|
|
}
|
|
|
|
private PostProcessingFactory postProcessingFactory;
|
|
|
|
private static native long nativeCreateAudioProcessing(long postProcessor);
|
|
}
|