72644d2cf6
Reason for revert: Breaks Chromium: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11313/steps/gclient%20runhooks/logs/stdio: Updating projects from gyp files... Using overrides found in /Users/chrome-bot/.gyp/include.gypi Traceback (most recent call last): File "src/build/gyp_chromium", line 12, in <module> execfile(__file__ + '.py') File "src/build/gyp_chromium.py", line 341, in <module> sys.exit(main()) File "src/build/gyp_chromium.py", line 328, in main gyp_rc = gyp.main(args) File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 538, in main return gyp_main(args) File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 514, in gyp_main options.duplicate_basename_check) File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 130, in Load params['parallel'], params['root_targets']) File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/input.py", line 2800, in Load RemoveLinkDependenciesFromNoneTargets(targets) File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/input.py", line 1510, in RemoveLinkDependenciesFromNoneTargets if targets[t].get('variables', {}).get('link_dependency', 0): KeyError: '/b/build/slave/Mac_Builder/build/src/third_party/webrtc/media/media.gyp:rtc_media_unittests#target' Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/Mac_Builder/build Hook '/usr/bin/python src/build/gyp_chromium' took 20.29 secs Original issue's description: > Remove {media,p2p,pc,xmllite,xmpp}_tests.gypi files. > > These contributes to circular dependency problems in WebRTC > since one have to depend on webrtc.gyp in order to depend on > a target in them. > > This reduces the number of cyclic dependencies in WebRTC from 21 > to 16. > > BUG=webrtc:4243 > NOTRY=True > NOPRESUBMIT=True > > Committed: https://crrev.com/231b69f28dd22f4e2d98e5048f8eaae7b20915e6 > Cr-Commit-Position: refs/heads/master@{#12166} TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4243 Review URL: https://codereview.webrtc.org/1846693002 Cr-Commit-Position: refs/heads/master@{#12167}
Name: WebRTC URL: http://www.webrtc.org Version: 90 License: BSD License File: LICENSE Description: WebRTC provides real time voice and video processing functionality to enable the implementation of PeerConnection/MediaStream. Third party code used in this project is described in the file LICENSE_THIRD_PARTY.