This reverts commit 7325bc3917e6dd4c92e7a18fd879ba91f0b2851f. Reason for revert: FecTest.UlpfecTest is consistently failing. Original change's description: > Refactor FEC code to use COW buffers > > This refactoring helps to reduce unnecessary memcpy calls on the receive > side. > > This CL is the first stage of refactoring: it only replaces > |uint8 data[IP_PACKET_SIZE]| with |rtc::CopyOnWriteBuffer data| and does > necessary changes. > > A follow-up CL will remove length field of the Packet class. > > > Bug: webrtc:10750 > Change-Id: Ie233da83ff33f6370f511955e4c65d59522389a7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144881 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28539} TBR=brandtr@webrtc.org,ilnik@webrtc.org,asapersson@webrtc.org,stefan@webrtc.org,titovartem@webrtc.org Change-Id: I07c34256a76174f09a0d27eacbae6488e66f4b43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10750 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145340 Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28545}
69 lines
2.5 KiB
C++
69 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <memory>
|
|
|
|
#include "modules/include/module_common_types_public.h"
|
|
#include "modules/rtp_rtcp/source/byte_io.h"
|
|
#include "modules/rtp_rtcp/source/fec_test_helper.h"
|
|
#include "modules/rtp_rtcp/source/ulpfec_generator.h"
|
|
#include "rtc_base/checks.h"
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
constexpr uint8_t kFecPayloadType = 96;
|
|
constexpr uint8_t kRedPayloadType = 97;
|
|
} // namespace
|
|
|
|
void FuzzOneInput(const uint8_t* data, size_t size) {
|
|
UlpfecGenerator generator;
|
|
size_t i = 0;
|
|
if (size < 4)
|
|
return;
|
|
FecProtectionParams params = {
|
|
data[i++] % 128, static_cast<int>(data[i++] % 10), kFecMaskBursty};
|
|
generator.SetFecParameters(params);
|
|
uint16_t seq_num = data[i++];
|
|
uint16_t prev_seq_num = 0;
|
|
while (i + 3 < size) {
|
|
size_t rtp_header_length = data[i++] % 10 + 12;
|
|
size_t payload_size = data[i++] % 10;
|
|
if (i + payload_size + rtp_header_length + 2 > size)
|
|
break;
|
|
std::unique_ptr<uint8_t[]> packet(
|
|
new uint8_t[payload_size + rtp_header_length]);
|
|
memcpy(packet.get(), &data[i], payload_size + rtp_header_length);
|
|
|
|
// Make sure sequence numbers are increasing.
|
|
ByteWriter<uint16_t>::WriteBigEndian(&packet[2], seq_num++);
|
|
i += payload_size + rtp_header_length;
|
|
const bool protect = data[i++] % 2 == 1;
|
|
|
|
// Check the sequence numbers are monotonic. In rare case the packets number
|
|
// may loop around and in the same FEC-protected group the packet sequence
|
|
// number became out of order.
|
|
if (protect && IsNewerSequenceNumber(seq_num, prev_seq_num) &&
|
|
seq_num < prev_seq_num + kUlpfecMaxMediaPackets) {
|
|
generator.AddRtpPacketAndGenerateFec(packet.get(), payload_size,
|
|
rtp_header_length);
|
|
prev_seq_num = seq_num;
|
|
}
|
|
const size_t num_fec_packets = generator.NumAvailableFecPackets();
|
|
if (num_fec_packets > 0) {
|
|
std::vector<std::unique_ptr<RedPacket>> fec_packets =
|
|
generator.GetUlpfecPacketsAsRed(kRedPayloadType, kFecPayloadType,
|
|
100);
|
|
RTC_CHECK_EQ(num_fec_packets, fec_packets.size());
|
|
}
|
|
}
|
|
}
|
|
} // namespace webrtc
|