58126f92bf
Bilinear is faster but lesser quality, box is best quality. Our code base has disagreed about which filter to use for quite some time, causing aliasing bug reports. In an effort to avoid aliasing artifacts and make our scaling filters more predictable, we're updating all uses to kFilterBox. WebRTC already uses kFilterBox everywhere except for these three places. The main discrepency was between Chromium and WebRTC but that has already been fixed. This CL fixes the last remaining bilinears. This brings the WebRTC kFilterBox use count up from 11 to 14 and the kFilterBilinear use count down from 3 to 0. Bug: chromium:1212630 Change-Id: I5fe4aa92b9275d65b91ea97925533055d190d317 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221372 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34248}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.