admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Steve Anton 8a006916ce Use RTCError for internal PeerConnection methods 
Calls to SetLocalDescription and SetRemoteDescription in
PeerConnection delegate to many different internal helper methods
which can fail. The error ultimately needs to propagate to the
caller and cause the SetXXXDescription to fail. Right now these
methods signal errors by returning false and copying the error
message into an out parameter. This changes these methods to
return RTCError instead and avoid the use of the out parameter.

Bug: webrtc:8587
Change-Id: Ib1d31622be742718b74780110c1bbe273d66444e
Reviewed-on: https://webrtc-review.googlesource.com/27241
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Reviewed-by: Zhi Huang <zhihuang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21061}
2017-12-05 00:04:39 +00:00
..
test
Reland "SetRemoteDescriptionObserverInterface added."
2017-11-23 19:59:48 +00:00
audiomonitor.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
audiomonitor.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
audiotrack.cc
Remove "using rtc::scoped_ptr" from audiotrack.cc.
2017-11-28 21:29:18 +00:00
audiotrack.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
BUILD.gn
Remove cricket::RtpTransceiverDirection
2017-11-27 23:04:17 +00:00
bundlefilter_unittest.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
bundlefilter.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
bundlefilter.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
channel_unittest.cc
Use the DtlsSrtpTransport in BaseChannel.
2017-11-29 19:38:39 +00:00
channel.cc
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
channel.h
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
channelmanager_unittest.cc
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
channelmanager.cc
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
channelmanager.h
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
createpeerconnectionfactory.cc
Remove deprecated CreatePeerConnectionFactory() overloads
2017-11-03 10:16:22 +00:00
currentspeakermonitor_unittest.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
currentspeakermonitor.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
currentspeakermonitor.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
datachannel_unittest.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
datachannel.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
datachannel.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
DEPS
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
dtlssrtptransport_unittest.cc
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
dtlssrtptransport.cc
Use the DtlsSrtpTransport in BaseChannel.
2017-11-29 19:38:39 +00:00
dtlssrtptransport.h
Make the DtlsSrtpTransport cache the RtpAbsSendTimeHeaderExtension.
2017-11-30 02:17:09 +00:00
dtmfsender_unittest.cc
Clean up dependencies of peerconnection_unittest.
2017-09-15 12:51:00 +00:00
dtmfsender.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
dtmfsender.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
externalhmac.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
externalhmac.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
iceserverparsing_unittest.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
iceserverparsing.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
iceserverparsing.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
jsepicecandidate.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
jsepsessiondescription_unittest.cc
Resolve circular dependency in rtc_media_base.
2017-11-28 15:28:58 +00:00
jsepsessiondescription.cc
Resolve circular dependency in rtc_media_base.
2017-11-28 15:28:58 +00:00
localaudiosource_unittest.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
localaudiosource.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
localaudiosource.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
mediaconstraintsinterface_unittest.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
mediamonitor.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
mediamonitor.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
mediasession_unittest.cc
Replace MediaContentDirection with RtpTransceiverDirection
2017-11-28 23:44:28 +00:00
mediasession.cc
Replace MediaContentDirection with RtpTransceiverDirection
2017-11-28 23:44:28 +00:00
mediasession.h
Remove transceiver direction getter/setter
2017-11-29 23:18:19 +00:00
mediastream_unittest.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
mediastream.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
mediastream.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
mediastreamobserver.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
mediastreamobserver.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
mediastreamtrack.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
OWNERS
Make hbos@webrtc.org OWNER of peerconnection*.
2017-11-13 12:27:29 +00:00
peerconnection_bundle_unittest.cc
Remove deprecated CreatePeerConnectionFactory() overloads
2017-11-03 10:16:22 +00:00
peerconnection_crypto_unittest.cc
Rewrite the remaining few WebRtcSession tests.
2017-10-23 21:05:17 +00:00
peerconnection_datachannel_unittest.cc
Rewrite WebRtcSession data channel tests as PeerConnection tests
2017-10-23 19:13:47 +00:00
peerconnection_ice_unittest.cc
Fixed a bug in determining ICE roles.
2017-12-04 20:08:28 +00:00
peerconnection_integrationtest.cc
Fixing some clang-tidy findings.
2017-11-21 16:43:07 +00:00
peerconnection_media_unittest.cc
Use RTCError for internal PeerConnection methods
2017-12-05 00:04:39 +00:00
peerconnection_rtp_unittest.cc
Reland "Add AddTransceiver and GetTransceivers to PeerConnection"
2017-11-27 22:27:49 +00:00
peerconnection_signaling_unittest.cc
Reland "Rewrite WebRtcSession media tests as PeerConnection tests"
2017-10-21 01:38:14 +00:00
peerconnection.cc
Use RTCError for internal PeerConnection methods
2017-12-05 00:04:39 +00:00
peerconnection.h
Use RTCError for internal PeerConnection methods
2017-12-05 00:04:39 +00:00
peerconnectionendtoend_unittest.cc
Optional: Use nullopt and implicit construction in /pc/peerconnectionendtoend_unittest.cc
2017-11-22 14:21:57 +00:00
peerconnectionfactory_unittest.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
peerconnectionfactory.cc
Sets names of peerconnection worker and network thread
2017-11-13 10:34:58 +00:00
peerconnectionfactory.h
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
peerconnectioninterface_unittest.cc
Replace MediaContentDirection with RtpTransceiverDirection
2017-11-28 23:44:28 +00:00
peerconnectionwrapper.cc
Reland "Add AddTransceiver and GetTransceivers to PeerConnection"
2017-11-27 22:27:49 +00:00
peerconnectionwrapper.h
Reland "Add AddTransceiver and GetTransceivers to PeerConnection"
2017-11-27 22:27:49 +00:00
proxy_unittest.cc
Clean up dependencies of peerconnection_unittest.
2017-09-15 12:51:00 +00:00
remoteaudiosource.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
remoteaudiosource.h
Fix flaky memory leak in RemoteAudioSource
2017-10-19 18:01:52 +00:00
rtcpmuxfilter_unittest.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
rtcpmuxfilter.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
rtcpmuxfilter.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
rtcstats_integrationtest.cc
Add network_type to local RTCIceCandidateStats
2017-11-21 19:58:37 +00:00
rtcstatscollector_unittest.cc
Use the new AudioProcessing statistics everywhere.
2017-11-24 18:17:39 +00:00
rtcstatscollector.cc
Use the new AudioProcessing statistics everywhere.
2017-11-24 18:17:39 +00:00
rtcstatscollector.h
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
rtpmediautils_unittest.cc
Remove cricket::RtpTransceiverDirection
2017-11-27 23:04:17 +00:00
rtpmediautils.cc
Replace MediaContentDirection with RtpTransceiverDirection
2017-11-28 23:44:28 +00:00
rtpmediautils.h
Replace MediaContentDirection with RtpTransceiverDirection
2017-11-28 23:44:28 +00:00
rtpreceiver.cc
Reland "Add AddTransceiver and GetTransceivers to PeerConnection"
2017-11-27 22:27:49 +00:00
rtpreceiver.h
Reland "Add AddTransceiver and GetTransceivers to PeerConnection"
2017-11-27 22:27:49 +00:00
rtpsender.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
rtpsender.h
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
rtpsenderreceiver_unittest.cc
Add streams() to RtpReceiverInterface and implementations.
2017-11-22 09:04:17 +00:00
rtptransceiver.cc
Add SDP semantics option to RTCConfiguration
2017-11-21 02:09:03 +00:00
rtptransceiver.h
Add SDP semantics option to RTCConfiguration
2017-11-21 02:09:03 +00:00
rtptransport_unittest.cc
Fixing some clang-tidy findings.
2017-11-21 16:43:07 +00:00
rtptransport.cc
Use the DtlsSrtpTransport in BaseChannel.
2017-11-29 19:38:39 +00:00
rtptransport.h
Use the DtlsSrtpTransport in BaseChannel.
2017-11-29 19:38:39 +00:00
rtptransportinternal.h
Use the DtlsSrtpTransport in BaseChannel.
2017-11-29 19:38:39 +00:00
rtptransportinternaladapter.h
Created the DtlsSrtpTransport.
2017-11-20 23:18:22 +00:00
rtptransporttestutil.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
sctputils_unittest.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
sctputils.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
sctputils.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
sdputils.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
sdputils.h
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
srtpfilter_unittest.cc
Fix ortc_api circular deps.
2017-11-15 13:31:51 +00:00
srtpfilter.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
srtpfilter.h
Fix ortc_api circular deps.
2017-11-15 13:31:51 +00:00
srtpsession_unittest.cc
Remove the SetEncryptedHeaderExtensionIds methods.
2017-11-11 01:14:35 +00:00
srtpsession.cc
Remove the SetEncryptedHeaderExtensionIds methods.
2017-11-11 01:14:35 +00:00
srtpsession.h
Remove the SetEncryptedHeaderExtensionIds methods.
2017-11-11 01:14:35 +00:00
srtptestutil.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
srtptransport_unittest.cc
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
srtptransport.cc
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
srtptransport.h
Prepare to make BaseChannel depend on RtpTransportInternal only.
2017-12-04 22:27:39 +00:00
statscollector_unittest.cc
Use the new AudioProcessing statistics everywhere.
2017-11-24 18:17:39 +00:00
statscollector.cc
Use the new AudioProcessing statistics everywhere.
2017-11-24 18:17:39 +00:00
statscollector.h
Add parallel stats interface with optional stats to APM.
2017-11-20 13:13:20 +00:00
streamcollection.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
trackmediainfomap_unittest.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
trackmediainfomap.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
trackmediainfomap.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
transportcontroller_unittest.cc
Move the TransportController from p2p/base to pc/.
2017-09-29 18:20:07 +00:00
transportcontroller.cc
Fixed a bug in determining ICE roles.
2017-12-04 20:08:28 +00:00
transportcontroller.h
Remove QUIC transport/data channel
2017-10-24 16:14:18 +00:00
videocapturertracksource_unittest.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
videocapturertracksource.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
videocapturertracksource.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
videotrack_unittest.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
videotrack.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
videotrack.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
videotracksource.cc
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
videotracksource.h
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
voicechannel.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
webrtcsdp_unittest.cc
Replace MediaContentDirection with RtpTransceiverDirection
2017-11-28 23:44:28 +00:00
webrtcsdp.cc
Replace MediaContentDirection with RtpTransceiverDirection
2017-11-28 23:44:28 +00:00
webrtcsdp.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
webrtcsessiondescriptionfactory.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
webrtcsessiondescriptionfactory.h
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00