6866dc7806
This reverts commit 28685dc08cb34f756f9200519fba3222ba3a66f2. Reason for revert: Speculative reland after looking into downstream failures. It's possible that carryover state from unrelated tests running in parallel was causing failures. Original change's description: > Revert "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase." > > This reverts commit 46b3bc6c24c233fe41a2401ce6e8eb8204a2d5a8. > > Reason for revert: Speculative revert. Breaks downstream project > > Original change's description: > > Make sure that "current" rtc::Thread instances are always current for TaskQueueBase. > > > > This is a necessary part of fulfilling the TaskQueueBase > > interface. If a thread does not register as the current TQ, yet offers > > the TQ interface, TQ 'current' checks will not work as expected and > > code that relies them (TaskQueueBase::Current() and IsCurrent()) > > will run in unexpected ways. > > > > Bug: webrtc:11572 > > Change-Id: Iab747bc474e74e6ce4f9e914cfd5b0578b19d19c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175080 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Tommi <tommi@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#31254} > > TBR=mbonadei@webrtc.org,tommi@webrtc.org > > Change-Id: I69ff3355f0ec447b25604bd95fdacbdb4d4f3f27 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:11572 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175104 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Commit-Queue: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31259} TBR=mbonadei@webrtc.org,tommi@webrtc.org,titovartem@webrtc.org # Not skipping CQ checks because this is a reland. Bug: webrtc:11572 Change-Id: I00c82d99af8e05851769e09cb682b5b73895a6f3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175133 Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31273}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.