3f42fdf19f
This reverts commit 3babb8af238a531cbff27951604b09bb78b762cd. Reason for revert: - Causes regressions to transceivers, see https://crbug.com/1291956 for more information, including tests to reproduce the issue. This CL is not a pure revert. While it reverts everything else, it does keep the new enum value (kProfilePredictiveHigh444). This is as to not break Chromium which already depend on it. It is not listed in the kProfilePatterns though so the enum value should never be applicable. Original change's description: > Added support for H264 YUV444 (I444) decoding. > > Added Nutanix Inc. to the AUTHORS file. > > PS#1 is a reland of "Added support for H264 YUV444 (I444) decoding." https://webrtc-review.googlesource.com/c/src/+/234540 > > Bug: chromium:1251096 > Change-Id: I99a1b1e4d8b60192ff96f92334a430240875c66c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235340 > Reviewed-by: Niels Moller <nisse@webrtc.org> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#35684} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1251096, chromium:1291956 Change-Id: Ib4d8ea4898f9832914d88e7076e6b39da0c804ca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249791 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Auto-Submit: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35835}
76 lines
3.1 KiB
C++
76 lines
3.1 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef COMMON_VIDEO_INCLUDE_VIDEO_FRAME_BUFFER_POOL_H_
|
|
#define COMMON_VIDEO_INCLUDE_VIDEO_FRAME_BUFFER_POOL_H_
|
|
|
|
#include <stddef.h>
|
|
|
|
#include <list>
|
|
|
|
#include "api/scoped_refptr.h"
|
|
#include "api/video/i420_buffer.h"
|
|
#include "api/video/nv12_buffer.h"
|
|
#include "rtc_base/race_checker.h"
|
|
#include "rtc_base/ref_counted_object.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Simple buffer pool to avoid unnecessary allocations of video frame buffers.
|
|
// The pool manages the memory of the I420Buffer/NV12Buffer returned from
|
|
// Create(I420|NV12)Buffer. When the buffer is destructed, the memory is
|
|
// returned to the pool for use by subsequent calls to Create(I420|NV12)Buffer.
|
|
// If the resolution passed to Create(I420|NV12)Buffer changes or requested
|
|
// pixel format changes, old buffers will be purged from the pool.
|
|
// Note that Create(I420|NV12)Buffer will crash if more than
|
|
// kMaxNumberOfFramesBeforeCrash are created. This is to prevent memory leaks
|
|
// where frames are not returned.
|
|
class VideoFrameBufferPool {
|
|
public:
|
|
VideoFrameBufferPool();
|
|
explicit VideoFrameBufferPool(bool zero_initialize);
|
|
VideoFrameBufferPool(bool zero_initialize, size_t max_number_of_buffers);
|
|
~VideoFrameBufferPool();
|
|
|
|
// Returns a buffer from the pool. If no suitable buffer exist in the pool
|
|
// and there are less than `max_number_of_buffers` pending, a buffer is
|
|
// created. Returns null otherwise.
|
|
rtc::scoped_refptr<I420Buffer> CreateI420Buffer(int width, int height);
|
|
rtc::scoped_refptr<NV12Buffer> CreateNV12Buffer(int width, int height);
|
|
|
|
// Changes the max amount of buffers in the pool to the new value.
|
|
// Returns true if change was successful and false if the amount of already
|
|
// allocated buffers is bigger than new value.
|
|
bool Resize(size_t max_number_of_buffers);
|
|
|
|
// Clears buffers_ and detaches the thread checker so that it can be reused
|
|
// later from another thread.
|
|
void Release();
|
|
|
|
private:
|
|
rtc::scoped_refptr<VideoFrameBuffer>
|
|
GetExistingBuffer(int width, int height, VideoFrameBuffer::Type type);
|
|
|
|
rtc::RaceChecker race_checker_;
|
|
std::list<rtc::scoped_refptr<VideoFrameBuffer>> buffers_;
|
|
// If true, newly allocated buffers are zero-initialized. Note that recycled
|
|
// buffers are not zero'd before reuse. This is required of buffers used by
|
|
// FFmpeg according to http://crbug.com/390941, which only requires it for the
|
|
// initial allocation (as shown by FFmpeg's own buffer allocation code). It
|
|
// has to do with "Use-of-uninitialized-value" on "Linux_msan_chrome".
|
|
const bool zero_initialize_;
|
|
// Max number of buffers this pool can have pending.
|
|
size_t max_number_of_buffers_;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // COMMON_VIDEO_INCLUDE_VIDEO_FRAME_BUFFER_POOL_H_
|