solenberg ffbbcac4c6 Support multiple timestamp rates for sending DTMF.
We support multiple payload types, and one which matches the audio codec the closest, is picked (or the one with lowest clock rate, if no perfect match is found).

The exact clock rate is then ignored and DTMF packets are time stamped with the rate of the current audio codec. This is exactly the way the code has worked up to this point, but until now we have been under the impression that we were in fact sending 8k DTMF.

In other words, this is an improvement over the current situation, since we will most likely find a payload type which matches the codec clock rate.

This CL also does a little cleaning of the DTMFQueue and RTPSenderAudio classes.
BUG=webrtc:2795

Review-Url: https://codereview.webrtc.org/2392883002
Cr-Commit-Position: refs/heads/master@{#15129}
2016-11-17 13:25:45 +00:00

48 lines
1.1 KiB
C++

/*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "webrtc/modules/rtp_rtcp/source/dtmf_queue.h"
namespace {
constexpr size_t kDtmfOutbandMax = 20;
}
namespace webrtc {
DtmfQueue::DtmfQueue() {}
DtmfQueue::~DtmfQueue() {}
bool DtmfQueue::AddDtmf(const Event& event) {
rtc::CritScope lock(&dtmf_critsect_);
if (queue_.size() >= kDtmfOutbandMax) {
return false;
}
queue_.push_back(event);
return true;
}
bool DtmfQueue::NextDtmf(Event* event) {
RTC_DCHECK(event);
rtc::CritScope lock(&dtmf_critsect_);
if (queue_.empty()) {
return false;
}
*event = queue_.front();
queue_.pop_front();
return true;
}
bool DtmfQueue::PendingDtmf() const {
rtc::CritScope lock(&dtmf_critsect_);
return !queue_.empty();
}
} // namespace webrtc