Taylor Brandstetter
dc4eb8c5b3
Refactoring some tests in peerconnectioninterface_unittest.cc.
...
Some tests were passing in a local description created from hard-coded
SDP strings, which won't work in the future (since some attributes such
as the fingerprint and ICE ufrag/pwd are non-modifiable). These tests
now do the typical approach of calling CreateOffer and modifying the
result if necessary.
Also added some non-const versions of the SessionDescription accessor
helper functions, since that makes it much easier to modify a
SessionDescription. Previous alternatives were re-implementing the
helper methods from scratch, or converting the description to SDP,
modifying it, and converting it back.
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1966333002 .
Cr-Commit-Position: refs/heads/master@{#12704}
2016-05-12 15:14:54 +00:00
..
2016-05-04 14:14:23 +00:00
2016-05-12 10:40:36 +00:00
2016-05-11 12:07:33 +00:00
2016-04-27 13:47:40 +00:00
2016-02-18 12:10:02 +00:00
2016-05-12 06:11:09 +00:00
2016-05-12 06:11:09 +00:00
2016-03-23 07:34:01 +00:00
2016-05-11 12:07:33 +00:00
2016-04-27 08:54:27 +00:00
2016-04-27 13:47:40 +00:00
2016-04-27 13:47:40 +00:00
2016-04-15 10:49:13 +00:00
2016-03-20 13:15:48 +00:00
2016-03-17 11:05:50 +00:00
2016-04-26 10:13:28 +00:00
2016-04-27 13:47:40 +00:00
2016-05-11 08:23:34 +00:00
2016-05-06 18:29:27 +00:00
2016-02-10 15:54:53 +00:00
2016-04-29 13:09:23 +00:00
2016-02-10 15:54:53 +00:00
2016-03-01 20:42:08 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 15:54:53 +00:00
2016-03-14 18:59:34 +00:00
2016-03-14 18:59:34 +00:00
2016-03-14 18:59:34 +00:00
2016-04-27 13:47:40 +00:00
2016-04-27 13:47:40 +00:00
2016-05-11 12:07:33 +00:00
2016-03-04 10:51:44 +00:00
2016-03-04 10:51:44 +00:00
2016-05-11 12:07:33 +00:00
2016-04-12 06:25:34 +00:00
2016-04-12 06:25:34 +00:00
2016-03-04 10:51:44 +00:00
2016-04-27 13:47:40 +00:00
2016-03-01 20:42:08 +00:00
2016-04-27 13:47:40 +00:00
2016-02-10 15:54:53 +00:00
2016-04-29 13:09:23 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 15:54:53 +00:00
2016-04-08 09:24:01 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 15:54:53 +00:00
2016-05-11 12:07:33 +00:00
2016-04-15 10:49:13 +00:00
2016-03-24 10:16:23 +00:00
2016-04-15 10:49:13 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 09:53:26 +00:00
2016-04-27 13:47:40 +00:00
2016-04-18 03:08:28 +00:00
2016-04-18 03:08:28 +00:00
2016-05-07 01:40:35 +00:00
2016-05-11 12:07:33 +00:00
2016-05-06 18:29:27 +00:00
2016-05-12 06:11:09 +00:00
2016-05-11 17:55:41 +00:00
2016-05-11 12:07:33 +00:00
2016-04-27 13:47:40 +00:00
2016-05-12 15:14:54 +00:00
2016-04-27 13:47:40 +00:00
2016-04-15 10:49:13 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 15:54:53 +00:00
2016-04-27 13:47:40 +00:00
2016-04-27 13:47:40 +00:00
2016-05-01 21:53:55 +00:00
2016-04-30 01:31:03 +00:00
2016-04-30 01:31:03 +00:00
2016-05-01 21:53:55 +00:00
2016-04-30 01:31:03 +00:00
2016-04-30 01:31:03 +00:00
2016-04-27 13:47:40 +00:00
2016-03-08 20:37:48 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 15:54:53 +00:00
2016-04-20 23:23:22 +00:00
2016-04-07 14:46:00 +00:00
2016-03-24 10:16:23 +00:00
2016-04-15 10:49:13 +00:00
2016-05-02 23:20:08 +00:00
2016-05-11 12:07:33 +00:00
2016-04-15 10:49:13 +00:00
2016-05-02 23:20:08 +00:00
2016-02-10 15:54:53 +00:00
2016-03-30 13:43:44 +00:00
2016-03-20 13:15:48 +00:00
2016-05-11 17:55:41 +00:00
2016-04-26 10:13:28 +00:00
2016-04-01 08:10:50 +00:00
2016-04-07 14:47:53 +00:00
2016-05-11 12:07:33 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 15:54:53 +00:00
2016-04-27 13:47:40 +00:00
2016-04-07 14:46:00 +00:00
2016-05-11 12:07:33 +00:00
2016-04-15 10:49:13 +00:00
2016-04-27 13:47:40 +00:00
2016-04-07 14:46:00 +00:00
2016-04-29 13:09:23 +00:00
2016-04-07 14:46:00 +00:00
2016-04-29 13:09:23 +00:00
2016-04-27 13:47:40 +00:00
2016-04-27 13:47:40 +00:00
2016-03-14 18:59:34 +00:00
2016-05-12 06:11:09 +00:00
2016-05-11 17:55:41 +00:00
2016-05-11 17:55:41 +00:00
2016-04-27 13:47:40 +00:00
2016-04-27 13:47:40 +00:00