66cadfc0e3
1. It looks like ComPtr cannot work well with vector::emplace_back, I got a consistent crash on one of my machine, but not the other. Move constructor should have no impact to lvalue reference, but I may be wrong here. The impact here is ComPtr released before it should be. So a simple solution is to use copy instead of reference. The D3dDevice is a collection of reference counted pointers (Microsoft::WRL::ComPtr), there is almost no extra cost. 2. Actively set several fields in D3D11_TEXTURE2D_DESC to avoid potential break if there are some platform changes later. 3. AcquireNextFrame returns both a DXGI_OUTDUPL_FRAME_INFO with AccumulatedFrames and an IDXGIResource. But there is no comment in MSDN to ensure IDXGIResource won't be nullptr if AccumulatedFrames > 0. Adding an extra check in DxgiOutputDuplicator makes it a safer. BUG=314516 Review-Url: https://codereview.webrtc.org/2345163002 Cr-Commit-Position: refs/heads/master@{#14341}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://chromium.googlesource.com/external/webrtc
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc