admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/webrtc/modules/audio_coding/neteq
History
henrik.lundin d5f50a1b53 NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger 
In some situation, typically when incoming packets were reordered, the
DelayPeakDetector::Update method may be called twice (or more) with
non-zero inter_arrival_time argument, but without the TickTimer object
being updated in between (i.e., packets coming in more or less at the
same time). In these situations, a delay peak may be registered with
zero peak period. This could eventually trigger the DCHECK in
DelayPeakDetector::MaxPeakPeriod().

With this fix, the problem is solved by not registering peaks for which
the TickTimer object has not moved since the last peak.

The problem was originally introduced with
https://codereview.webrtc.org/1921163003.

BUG=webrtc:6021

Review-Url: https://codereview.webrtc.org/2085233002
Cr-Commit-Position: refs/heads/master@{#13257}
2016-06-22 16:07:07 +00:00
..
include
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
mock
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
test
Enable -Winconsistent-missing-override flag.
2016-04-29 13:09:23 +00:00
tools
Refactor neteq_rtpplay
2016-06-22 13:34:08 +00:00
accelerate.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
accelerate.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
audio_classifier_unittest.cc
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/
2016-02-14 17:28:39 +00:00
audio_classifier.cc
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
audio_classifier.h
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/
2016-02-14 17:28:39 +00:00
audio_decoder_impl.cc
NetEq decoder database: Don't keep track of sample rate for builtin decoders
2016-05-31 13:28:09 +00:00
audio_decoder_impl.h
NetEq decoder database: Don't keep track of sample rate for builtin decoders
2016-05-31 13:28:09 +00:00
audio_decoder_unittest.cc
NetEq decoder database: Don't keep track of sample rate for builtin decoders
2016-05-31 13:28:09 +00:00
audio_multi_vector_unittest.cc
Change NetEq::GetAudio to use AudioFrame
2016-03-04 18:34:26 +00:00
audio_multi_vector.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
audio_multi_vector.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
audio_vector_unittest.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
audio_vector.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
audio_vector.h
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
background_noise_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
background_noise.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
background_noise.h
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/
2016-02-14 17:28:39 +00:00
buffer_level_filter_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
buffer_level_filter.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
buffer_level_filter.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
comfort_noise_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
comfort_noise.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
comfort_noise.h
Convert CNG into C++ and remove it from AudioDecoder
2016-04-25 14:56:05 +00:00
cross_correlation.cc
Reland "Avoiding overflow in cross correlation in NetEq."
2016-05-02 08:50:34 +00:00
cross_correlation.h
Reland "Avoiding overflow in cross correlation in NetEq."
2016-05-02 08:50:34 +00:00
decision_logic_fax.cc
NetEq: Move counting of generated CNG samples from DecisionLogic
2016-05-03 15:18:54 +00:00
decision_logic_fax.h
NetEq: Replace timescale_holdoff_ with a Countdown timer
2016-05-10 08:21:11 +00:00
decision_logic_normal.cc
NetEq: Move counting of generated CNG samples from DecisionLogic
2016-05-03 15:18:54 +00:00
decision_logic_normal.h
NetEq: Replace timescale_holdoff_ with a Countdown timer
2016-05-10 08:21:11 +00:00
decision_logic_unittest.cc
Turned AudioDecoderFactory into a RefCounted thing to use with scoped_refptr.
2016-05-19 17:48:12 +00:00
decision_logic.cc
NetEq: Replace timescale_holdoff_ with a Countdown timer
2016-05-10 08:21:11 +00:00
decision_logic.h
NetEq: Replace timescale_holdoff_ with a Countdown timer
2016-05-10 08:21:11 +00:00
decoder_database_unittest.cc
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
decoder_database.cc
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
decoder_database.h
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
defines.h
Add new fast mode for NetEq's Accelerate operation
2015-05-27 12:33:39 +00:00
delay_manager_unittest.cc
NetEq: Use TickTimer in DelayManager
2016-04-29 06:19:27 +00:00
delay_manager.cc
NetEq: Use TickTimer in DelayManager
2016-04-29 06:19:27 +00:00
delay_manager.h
NetEq: Use TickTimer in DelayManager
2016-04-29 06:19:27 +00:00
delay_peak_detector_unittest.cc
NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger
2016-06-22 16:07:07 +00:00
delay_peak_detector.cc
NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger
2016-06-22 16:07:07 +00:00
delay_peak_detector.h
Replace scoped_ptr with unique_ptr everywhere
2016-05-01 21:53:55 +00:00
dsp_helper_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
dsp_helper.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
dsp_helper.h
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
dtmf_buffer_unittest.cc
Switch to base/logging.h in neteq_impl.cc
2015-08-03 10:55:11 +00:00
dtmf_buffer.cc
Add RTC_ prefix to (D)CHECKs and related macros.
2015-09-17 07:24:51 +00:00
dtmf_buffer.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
dtmf_tone_generator_unittest.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
dtmf_tone_generator.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
dtmf_tone_generator.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
expand_unittest.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
expand.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
expand.h
NetEq: Implement Expand::Muted
2016-05-10 12:54:43 +00:00
merge_unittest.cc
NetEq: Implement logging of Delayed Packet Outage Events
2015-08-18 12:58:20 +00:00
merge.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
merge.h
Adding 120 ms frame length support in NetEq.
2016-05-02 11:46:19 +00:00
nack_tracker_unittest.cc
NetEq: Rename Nack to NackTracker to avoid name collisions in GN
2016-06-08 13:43:49 +00:00
nack_tracker.cc
NetEq: Rename Nack to NackTracker to avoid name collisions in GN
2016-06-08 13:43:49 +00:00
nack_tracker.h
NetEq: Rename Nack to NackTracker to avoid name collisions in GN
2016-06-08 13:43:49 +00:00
neteq_external_decoder_unittest.cc
AudioDecoder: Remove the default implementation of SampleRateHz
2016-06-16 08:59:13 +00:00
neteq_impl_unittest.cc
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
neteq_impl.cc
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
neteq_impl.h
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument
2016-06-16 10:18:09 +00:00
neteq_network_stats_unittest.cc
AudioDecoder: Remove the default implementation of SampleRateHz
2016-06-16 08:59:13 +00:00
neteq_stereo_unittest.cc
Moved injection of AudioDecoderFactory into voe::Channel.
2016-05-25 14:37:47 +00:00
neteq_tests.gypi
Refactor neteq_rtpplay
2016-06-22 13:34:08 +00:00
neteq_unittest.cc
NetEq: Fix stats counting in muted mode
2016-05-25 15:21:09 +00:00
neteq_unittest.proto
Update NetEq network statistics in neteq_unittest.
2015-12-16 15:36:10 +00:00
neteq.cc
Moved injection of AudioDecoderFactory into voe::Channel.
2016-05-25 14:37:47 +00:00
neteq.gypi
Refactor neteq_rtpplay
2016-06-22 13:34:08 +00:00
normal_unittest.cc
Adding 120 ms frame length support in NetEq.
2016-05-02 11:46:19 +00:00
normal.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
normal.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
OWNERS
Simplify OWNERS structure in modules/audio_coding
2015-06-29 11:54:50 +00:00
packet_buffer_unittest.cc
NetEq: Use TickTimer in PacketBuffer
2016-04-26 14:45:26 +00:00
packet_buffer.cc
NetEq: Use TickTimer in PacketBuffer
2016-04-26 14:45:26 +00:00
packet_buffer.h
NetEq: Use TickTimer in PacketBuffer
2016-04-26 14:45:26 +00:00
packet.cc
NetEq: Use TickTimer in PacketBuffer
2016-04-26 14:45:26 +00:00
packet.h
NetEq: Use TickTimer in PacketBuffer
2016-04-26 14:45:26 +00:00
payload_splitter_unittest.cc
NetEq decoder database: Don't keep track of sample rate for builtin decoders
2016-05-31 13:28:09 +00:00
payload_splitter.cc
NetEq: Use TickTimer in PacketBuffer
2016-04-26 14:45:26 +00:00
payload_splitter.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
post_decode_vad_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
post_decode_vad.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
post_decode_vad.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
preemptive_expand.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
preemptive_expand.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
random_vector_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
random_vector.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
random_vector.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
rtcp.cc
modules: more interface -> include renames
2015-11-04 07:32:04 +00:00
rtcp.h
audio_coding: rename interface -> include
2015-10-29 10:31:11 +00:00
statistics_calculator.cc
Revert of Safe numeric library: base/numerics (copied from Chromium) (patchset #11 id:250001 of https://codereview.webrtc.org/1753293002/ )
2016-03-12 01:12:40 +00:00
statistics_calculator.h
audio_coding: rename interface -> include
2015-10-29 10:31:11 +00:00
sync_buffer_unittest.cc
Change NetEq::GetAudio to use AudioFrame
2016-03-04 18:34:26 +00:00
sync_buffer.cc
Remove unused stuff from AudioFrame:
2016-03-29 23:42:12 +00:00
sync_buffer.h
Unit test for AudioFrame output from AcmReceiver::GetAudio
2016-04-06 08:03:07 +00:00
tick_timer_unittest.cc
Replace the remaining scoped_ptr with unique_ptr in webrtc/modules/
2016-04-27 08:20:08 +00:00
tick_timer.cc
Add a new TickTimer class to NetEq
2016-04-22 20:21:49 +00:00
tick_timer.h
Add a new TickTimer class to NetEq
2016-04-22 20:21:49 +00:00
time_stretch_unittest.cc
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/
2016-02-14 17:28:39 +00:00
time_stretch.cc
Reland "Avoiding overflow in cross correlation in NetEq."
2016-05-02 08:50:34 +00:00
time_stretch.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
timestamp_scaler_unittest.cc
NetEq decoder database: Don't keep track of sample rate for builtin decoders
2016-05-31 13:28:09 +00:00
timestamp_scaler.cc
Fix two UBSan warnings in NetEq
2016-02-11 11:35:51 +00:00
timestamp_scaler.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00