Macros defined in rtc_base/flags.h are intended to be used to define
flags in WebRTC's binaries (e.g. tests).
They are currently not prefixed and this could cause problems with
downstream clients since these names are quite common.
This CL adds the 'WEBRTC_' prefix to them.
Generated with:
for x in DECLARE DEFINE; do
for y in bool int float string FLAG; do
git grep -l "\b$x\_$y\b" | \
xargs sed -i "s/\b$x\_$y\b/WEBRTC_$x\_$y/g"
done
done
git cl format
Bug: webrtc:9884
Change-Id: I7b524762b6a3e5aa5b2fc2395edd3e1a0fe72591
Reviewed-on: https://webrtc-review.googlesource.com/c/106682
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25270}
63 lines
1.9 KiB
C++
63 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "test/testsupport/test_artifacts.h"
|
|
|
|
#include <string.h>
|
|
|
|
#include <string>
|
|
|
|
#include "rtc_base/file.h"
|
|
#include "rtc_base/flags.h"
|
|
#include "rtc_base/pathutils.h"
|
|
#include "rtc_base/platform_file.h"
|
|
#include "test/gtest.h"
|
|
#include "test/testsupport/fileutils.h"
|
|
|
|
WEBRTC_DECLARE_string(test_artifacts_dir);
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
TEST(IsolatedOutputTest, ShouldRejectInvalidIsolatedOutDir) {
|
|
const char* backup = FLAG_test_artifacts_dir;
|
|
FLAG_test_artifacts_dir = "";
|
|
ASSERT_FALSE(WriteToTestArtifactsDir("a-file", "some-contents"));
|
|
FLAG_test_artifacts_dir = backup;
|
|
}
|
|
|
|
TEST(IsolatedOutputTest, ShouldRejectInvalidFileName) {
|
|
ASSERT_FALSE(WriteToTestArtifactsDir(nullptr, "some-contents"));
|
|
ASSERT_FALSE(WriteToTestArtifactsDir("", "some-contents"));
|
|
}
|
|
|
|
// Sets isolated_out_dir=<a-writable-path> to execute this test.
|
|
TEST(IsolatedOutputTest, ShouldBeAbleToWriteContent) {
|
|
const char* filename = "a-file";
|
|
const char* content = "some-contents";
|
|
if (WriteToTestArtifactsDir(filename, content)) {
|
|
std::string out_file = JoinFilename(FLAG_test_artifacts_dir, filename);
|
|
rtc::File input = rtc::File::Open(out_file);
|
|
EXPECT_TRUE(input.IsOpen());
|
|
EXPECT_TRUE(input.Seek(0));
|
|
uint8_t buffer[32];
|
|
EXPECT_EQ(input.Read(buffer, strlen(content)), strlen(content));
|
|
buffer[strlen(content)] = 0;
|
|
EXPECT_EQ(std::string(content),
|
|
std::string(reinterpret_cast<char*>(buffer)));
|
|
input.Close();
|
|
|
|
EXPECT_TRUE(rtc::File::Remove(out_file));
|
|
}
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|