admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Steve Anton 5c72e71e14 [Unified Plan] Fix issues with recycling m= sections 
Previously, the PeerConnection would look at the pending local
and remote descriptions also to determine if an m= section is
recycled. That is not quite spec compliant and breaks down under
some edge cases. This changes the PeerConnection to look only at
the *current* local or remote description (i.e., the descriptions
from the last time the PeerConnection was in a stable signaling
state) to determine if an m= section is recycled.

Additionally, the MediaSessionFactory only looked at the local
description to determine if an m= section is recycled. The full
criteria requires looking at the current local and current remote
m= sections. This change adds a state enum to the
MediaDescriptionOptions so that the MediaSessionFactory knows if
a media section is being recycled without duplicating the logic
in PeerConnection.

Tests are added to cover additional edge cases.

Bug: chromium:899680
Change-Id: I5bcf0f88957a61653269ed8bb50b2018500bc1d5
Reviewed-on: https://webrtc-review.googlesource.com/c/111293
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25959}
2018-12-10 23:38:55 +00:00
..
test
Add LookupDtlsTransportByMid to proxy map
2018-12-04 10:29:32 +00:00
audiotrack.cc
Remove "using rtc::scoped_ptr" from audiotrack.cc.
2017-11-28 21:29:18 +00:00
audiotrack.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
BUILD.gn
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
channel_unittest.cc
Explicit comparisons on NetworkRoute.
2018-12-04 12:36:50 +00:00
channel.cc
Implement TargetBitrate, NetworkRoute and overhead features of media transport interface.
2018-11-16 19:31:11 +00:00
channel.h
Implement TargetBitrate, NetworkRoute and overhead features of media transport interface.
2018-11-16 19:31:11 +00:00
channelinterface.h
Prevent channels being set on stopped transceiver.
2018-11-14 16:23:07 +00:00
channelmanager_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
channelmanager.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
channelmanager.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
datachannel_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
datachannel.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
datachannel.h
Implement data channels over media transport.
2018-11-09 00:40:32 +00:00
DEPS
Allows injection of network controller factory into peer connection factory.
2018-05-18 17:07:16 +00:00
dtlssrtptransport_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
dtlssrtptransport.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
dtlssrtptransport.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
dtlstransport.cc
Add API for returning a webrtc::DtlsTransport for a MID on a PC
2018-11-28 19:39:28 +00:00
dtlstransport.h
Delete a cricket::DtlsTransport when PC is closed
2018-12-06 12:06:34 +00:00
dtmfsender_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
dtmfsender.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
dtmfsender.h
Use AsyncInvoker in DtmfSender instead of MessageHandler
2018-08-31 22:49:26 +00:00
externalhmac.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
externalhmac.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
iceserverparsing_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
iceserverparsing.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
iceserverparsing.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
jsepicecandidate.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
jsepsessiondescription_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
jsepsessiondescription.cc
Move SdpType from/to string definition close to declaration.
2018-10-12 09:59:40 +00:00
jseptransport_unittest.cc
Add API for returning a webrtc::DtlsTransport for a MID on a PC
2018-11-28 19:39:28 +00:00
jseptransport.cc
Make sure media transport is deleted before ICE.
2018-12-06 18:11:28 +00:00
jseptransport.h
Add API for returning a webrtc::DtlsTransport for a MID on a PC
2018-11-28 19:39:28 +00:00
jseptransportcontroller_unittest.cc
Update connection states to match spec changes.
2018-12-10 10:01:24 +00:00
jseptransportcontroller.cc
Update connection states to match spec changes.
2018-12-10 10:01:24 +00:00
jseptransportcontroller.h
Add API for returning a webrtc::DtlsTransport for a MID on a PC
2018-11-28 19:39:28 +00:00
localaudiosource_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
localaudiosource.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
localaudiosource.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
mediaconstraintsinterface_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
mediasession_unittest.cc
[Unified Plan] Fix issues with recycling m= sections
2018-12-10 23:38:55 +00:00
mediasession.cc
[Unified Plan] Fix issues with recycling m= sections
2018-12-10 23:38:55 +00:00
mediasession.h
[Unified Plan] Fix issues with recycling m= sections
2018-12-10 23:38:55 +00:00
mediastream_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
mediastream.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
mediastream.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
mediastreamobserver.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
mediastreamobserver.h
Move sigslot to proper third_party directory
2018-07-25 14:53:33 +00:00
mediastreamtrack.h
…
OWNERS
Adding shampson (me) as an owner to pc/ & api/.
2018-07-03 20:39:17 +00:00
peerconnection_bundle_unittest.cc
Add API for returning a webrtc::DtlsTransport for a MID on a PC
2018-11-28 19:39:28 +00:00
peerconnection_crypto_unittest.cc
Move webrtc::CreatePeerConnectionFactory definition next to decl.
2018-11-22 09:07:51 +00:00
peerconnection_datachannel_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
peerconnection_histogram_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
peerconnection_ice_unittest.cc
Move webrtc::CreatePeerConnectionFactory definition next to decl.
2018-11-22 09:07:51 +00:00
peerconnection_integrationtest.cc
Update connection states to match spec changes.
2018-12-10 10:01:24 +00:00
peerconnection_jsep_unittest.cc
[Unified Plan] Fix issues with recycling m= sections
2018-12-10 23:38:55 +00:00
peerconnection_media_unittest.cc
Exposing audio and video engines directly.
2018-11-16 15:40:45 +00:00
peerconnection_rampup_tests.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
peerconnection_rtp_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
peerconnection_signaling_unittest.cc
Move webrtc::CreatePeerConnectionFactory definition next to decl.
2018-11-22 09:07:51 +00:00
peerconnection.cc
[Unified Plan] Fix issues with recycling m= sections
2018-12-10 23:38:55 +00:00
peerconnection.h
Export the standardized IceConnectionState.
2018-12-07 09:54:59 +00:00
peerconnectionendtoend_unittest.cc
Run some peer connection end-to-end tests with an empty audio encoder factory
2018-11-13 16:14:50 +00:00
peerconnectionfactory_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
peerconnectionfactory.cc
Exposing audio and video engines directly.
2018-11-16 15:40:45 +00:00
peerconnectionfactory.h
Pass MediaTransportFactory to PeerConnectionFactory.
2018-10-08 18:11:06 +00:00
peerconnectioninterface_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
peerconnectioninternal.h
[Unified Plan] Fix old GetStats() not associating track id
2018-11-28 20:22:10 +00:00
peerconnectionwrapper.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
peerconnectionwrapper.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
proxy_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
remoteaudiosource.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
remoteaudiosource.h
Configure media flow correctly with Unified Plan
2018-01-18 19:01:38 +00:00
rtcpmuxfilter_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtcpmuxfilter.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcpmuxfilter.h
Move sessiondescription.h/cc from p2p/base to pc/
2017-12-20 00:21:52 +00:00
rtcstats_integrationtest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtcstatscollector_unittest.cc
Expose delayed packet outage as a cumulative metric of samples in the new getStats API.
2018-11-27 15:10:09 +00:00
rtcstatscollector.cc
Expose delayed packet outage as a cumulative metric of samples in the new getStats API.
2018-11-27 15:10:09 +00:00
rtcstatscollector.h
Move sigslot to proper third_party directory
2018-07-25 14:53:33 +00:00
rtcstatstraversal_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtcstatstraversal.cc
RTCStatsCollector::GetStatsReport() with optional selector argument.
2018-03-19 15:32:16 +00:00
rtcstatstraversal.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtpmediautils_unittest.cc
Implement legacy offer_to_receive options for Unified Plan
2018-01-27 02:20:29 +00:00
rtpmediautils.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtpmediautils.h
Reland "Reland "Remove our stream << overloads from non-test build targets.""
2018-05-03 10:41:41 +00:00
rtpparametersconversion_unittest.cc
Remove multiple RTX codec entries in GetRtpReceiver/SenderCapabilities
2018-11-07 15:35:56 +00:00
rtpparametersconversion.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtpparametersconversion.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtpreceiver.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtpreceiver.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtpsender.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtpsender.h
Prevent channels being set on stopped transceiver.
2018-11-14 16:23:07 +00:00
rtpsenderreceiver_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtptransceiver_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtptransceiver.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtptransceiver.h
Prevent channels being set on stopped transceiver.
2018-11-14 16:23:07 +00:00
rtptransport_unittest.cc
Explicit comparisons on NetworkRoute.
2018-12-04 12:36:50 +00:00
rtptransport.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
rtptransport.h
Delete struct rtc::PacketTime.
2018-11-05 16:21:39 +00:00
rtptransportinternal.h
Delete struct rtc::PacketTime.
2018-11-05 16:21:39 +00:00
rtptransportinternaladapter.h
Remove MetricsObserverInterface.
2018-07-19 23:00:20 +00:00
rtptransporttestutil.h
Delete struct rtc::PacketTime.
2018-11-05 16:21:39 +00:00
sctputils_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
sctputils.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
sctputils.h
…
sdpserializer_unittest.cc
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
sdpserializer.cc
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
sdpserializer.h
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
sdputils.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
sdputils.h
Move sessiondescription.h/cc from p2p/base to pc/
2017-12-20 00:21:52 +00:00
sessiondescription_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
sessiondescription.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
sessiondescription.h
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
simulcastdescription.cc
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
simulcastdescription.h
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
srtpfilter_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
srtpfilter.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
srtpfilter.h
When SDES is used, pass pre-shared key to media transport.
2018-10-31 16:04:16 +00:00
srtpsession_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
srtpsession.cc
Throttle the RTP decryption error messages in the SrtpSession and SrtpTransport
2018-10-09 12:10:55 +00:00
srtpsession.h
Throttle the RTP decryption error messages in the SrtpSession and SrtpTransport
2018-10-09 12:10:55 +00:00
srtptestutil.h
…
srtptransport_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
srtptransport.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
srtptransport.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
statscollector_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
statscollector.cc
New statistic added to VideoReceiveStream to determine latency to first decode.
2018-12-10 18:49:34 +00:00
statscollector.h
[Unified Plan] Fix old GetStats() not associating track id
2018-11-28 20:22:10 +00:00
streamcollection.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
trackmediainfomap_unittest.cc
Replace rtc::Optional with absl::optional in pc
2018-06-19 20:55:07 +00:00
trackmediainfomap.cc
Replace rtc::Optional with absl::optional in pc
2018-06-19 20:55:07 +00:00
trackmediainfomap.h
Replace rtc::Optional with absl::optional in pc
2018-06-19 20:55:07 +00:00
transportstats.cc
Create the JsepTransportController and JsepTransport2.
2018-02-23 00:13:45 +00:00
transportstats.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
videocapturertracksource_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
videocapturertracksource.cc
Replace rtc::Optional with absl::optional in pc
2018-06-19 20:55:07 +00:00
videocapturertracksource.h
Move sigslot to proper third_party directory
2018-07-25 14:53:33 +00:00
videotrack_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
videotrack.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
videotrack.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
videotracksource.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
videotracksource.h
Export symbols needed by the Chromium component build (part 2).
2018-10-15 19:52:31 +00:00
webrtcsdp_unittest.cc
[Unified Plan] If "a=msid" is missing, create default stream.
2018-12-05 09:53:21 +00:00
webrtcsdp.cc
Adding SDP parsing for Simulcast.
2018-12-03 20:13:53 +00:00
webrtcsdp.h
Export symbols needed by the Chromium component build (part 7).
2018-10-25 11:41:16 +00:00
webrtcsessiondescriptionfactory.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
webrtcsessiondescriptionfactory.h
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00