7978cf1b43
The plan is to replace Members() with Attributes() instead.
For backwards-compatability during the transition, Attribute implements
RTCStatsMemberInterface but the two classes serve the same purpose
which is to allow iterating all metrics of a stats object.
The reason for moving away from "members" is that we already have a way
to express a variable that maybe has a value: absl::optional<T>. The
only information the member adds is the const char* name(), which we'll
move to Attribute in a future CL.
We don't need to maintain an RTCStatsMemberInterface::Type enum in the
future because absl::variant<T> has absl::holds_alternative<T>.
Step 1: Add Attributes().
Step 2: Migrate to Attributes() and delete Members().
Step 3: Replaces all uses of RTCStatsMember<T> with absl::optional<T>
and delete RTCStatsMember + RTCStatsMemberInterface.
Bug: webrtc:15164
Change-Id: I3fdd5b24214bb5cc340a54a0171df73b516e1803
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333840
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41507}
91 lines
2.6 KiB
C++
91 lines
2.6 KiB
C++
/*
|
|
* Copyright 2016 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/stats/rtc_stats.h"
|
|
|
|
#include <cstdio>
|
|
|
|
#include "rtc_base/strings/string_builder.h"
|
|
|
|
namespace webrtc {
|
|
|
|
RTCStats::RTCStats(const RTCStats& other)
|
|
: RTCStats(other.id_, other.timestamp_) {}
|
|
|
|
RTCStats::~RTCStats() {}
|
|
|
|
bool RTCStats::operator==(const RTCStats& other) const {
|
|
if (type() != other.type() || id() != other.id())
|
|
return false;
|
|
std::vector<const RTCStatsMemberInterface*> members = Members();
|
|
std::vector<const RTCStatsMemberInterface*> other_members = other.Members();
|
|
RTC_DCHECK_EQ(members.size(), other_members.size());
|
|
for (size_t i = 0; i < members.size(); ++i) {
|
|
const RTCStatsMemberInterface* member = members[i];
|
|
const RTCStatsMemberInterface* other_member = other_members[i];
|
|
RTC_DCHECK_EQ(member->type(), other_member->type());
|
|
RTC_DCHECK_EQ(member->name(), other_member->name());
|
|
if (*member != *other_member)
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool RTCStats::operator!=(const RTCStats& other) const {
|
|
return !(*this == other);
|
|
}
|
|
|
|
std::string RTCStats::ToJson() const {
|
|
rtc::StringBuilder sb;
|
|
sb << "{\"type\":\"" << type()
|
|
<< "\","
|
|
"\"id\":\""
|
|
<< id_
|
|
<< "\","
|
|
"\"timestamp\":"
|
|
<< timestamp_.us();
|
|
for (const RTCStatsMemberInterface* member : Members()) {
|
|
if (member->is_defined()) {
|
|
sb << ",\"" << member->name() << "\":";
|
|
if (member->is_string())
|
|
sb << "\"" << member->ValueToJson() << "\"";
|
|
else
|
|
sb << member->ValueToJson();
|
|
}
|
|
}
|
|
sb << "}";
|
|
return sb.Release();
|
|
}
|
|
|
|
std::vector<const RTCStatsMemberInterface*> RTCStats::Members() const {
|
|
if (cached_attributes_.empty()) {
|
|
cached_attributes_ = Attributes();
|
|
}
|
|
std::vector<const RTCStatsMemberInterface*> members;
|
|
members.reserve(cached_attributes_.size());
|
|
for (const auto& attribute : cached_attributes_) {
|
|
members.push_back(&attribute);
|
|
}
|
|
return members;
|
|
}
|
|
|
|
std::vector<Attribute> RTCStats::Attributes() const {
|
|
return AttributesImpl(0);
|
|
}
|
|
|
|
std::vector<Attribute> RTCStats::AttributesImpl(
|
|
size_t additional_capacity) const {
|
|
std::vector<Attribute> attributes;
|
|
attributes.reserve(additional_capacity);
|
|
return attributes;
|
|
}
|
|
|
|
} // namespace webrtc
|