4cc9f98e4c
When remote side closes, opensslstreamadapter could return SR_EOS which will not trigger upper layer to clean up what's left in the StreamInterfaceChannel. The result of this is when there are more packets coming in, the Write on the StreamInterfaceChannel will overflow the buffer. The fix here is that when receiving the remote side close signal, we also close the underneath StreamInterfaceChannel which will clean up the queue to prevent overflow. BUG=574524 TBR=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1566023002 Cr-Commit-Position: refs/heads/master@{#11751}
61 lines
1.8 KiB
C++
61 lines
1.8 KiB
C++
/*
|
|
* Copyright 2015 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_BUFFERQUEUE_H_
|
|
#define WEBRTC_BASE_BUFFERQUEUE_H_
|
|
|
|
#include <deque>
|
|
#include <vector>
|
|
|
|
#include "webrtc/base/buffer.h"
|
|
#include "webrtc/base/criticalsection.h"
|
|
|
|
namespace rtc {
|
|
|
|
class BufferQueue {
|
|
public:
|
|
// Creates a buffer queue with a given capacity and default buffer size.
|
|
BufferQueue(size_t capacity, size_t default_size);
|
|
virtual ~BufferQueue();
|
|
|
|
// Return number of queued buffers.
|
|
size_t size() const;
|
|
|
|
// Clear the BufferQueue by moving all Buffers from |queue_| to |free_list_|.
|
|
void Clear();
|
|
|
|
// ReadFront will only read one buffer at a time and will truncate buffers
|
|
// that don't fit in the passed memory.
|
|
// Returns true unless no data could be returned.
|
|
bool ReadFront(void* data, size_t bytes, size_t* bytes_read);
|
|
|
|
// WriteBack always writes either the complete memory or nothing.
|
|
// Returns true unless no data could be written.
|
|
bool WriteBack(const void* data, size_t bytes, size_t* bytes_written);
|
|
|
|
protected:
|
|
// These methods are called when the state of the queue changes.
|
|
virtual void NotifyReadableForTest() {}
|
|
virtual void NotifyWritableForTest() {}
|
|
|
|
private:
|
|
size_t capacity_;
|
|
size_t default_size_;
|
|
CriticalSection crit_;
|
|
std::deque<Buffer*> queue_ GUARDED_BY(crit_);
|
|
std::vector<Buffer*> free_list_ GUARDED_BY(crit_);
|
|
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(BufferQueue);
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_BUFFERQUEUE_H_
|