4fc0855a39
In several places VideoFrame::Builder is used to create a new VideoFrame when intent is to change only one or two fields of a const VideoFrame&. This approach is bad because each and every metadata field have to be added to all the places. Instead, this CL adds missing setters and refactors the code to use full copy of a VideoFrame and update required fields only. Along the way few actual bugs are fixed, e.g. when ColorSpace isn't copied when frame rotation or buffer is cropped or converted. Bug: webrtc:10460 Change-Id: I2895a473ca938b150eed2916c689060bdf58cb25 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140102 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28170}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.