1a58a3fe3f
This is a reland of 7b370b935ec0dac991da08f9da227df9ce245fd5 Original change's description: > Delete implicit conversion from raw pointer to scoped_ref_ptr > > Followup to https://webrtc-review.googlesource.com/c/src/+/242363 > > Bug: webrtc:13464 > Change-Id: I44358e8cfedeea92aac4ef47c540aff9a4865cdc > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247362 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#35897} Bug: webrtc:13464 Change-Id: Ia0da558adb65852a900030ca7c2f2310a275188e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251140 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35943}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.