48e7065ac6
One-byte RTP extensions may only have IDs in the range 1-14. For higher IDs, the two-byte format must be used. If default IDs are set for all extensions, once 15 extensions are defined by the code, some extensions will have IDs greater than 14. This will happen even if only one extension actually ends up being offered, so long as it's that unfortunate RTP extension. It's better to dynamically assign the IDs to those extensions we actually offer. The code that assigns the IDs is currently distributed ( WebRtcVoiceEngine::GetCapabilities() and WebRtcVideoEngine::GetCapabilities()), and without a bigger refactoring effort would produce some ID collisions and mismatches. Those are already handled by MergeRtpHdrExts(), so so that should not be a problem. Bug: webrtc:10288 Change-Id: I087f1ed5baa9fd61fd5556f1d82f540304ec6b93 Reviewed-on: https://webrtc-review.googlesource.com/c/122480 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26876}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.