487f9a17e4
Also clears SctpTransport before deleting JsepTransport. SctpTransport is ref-counted, but the underlying transport is deleted when JsepTransport clears the rtp_dtls_transport. This results in crashes when usrsctp attempts to send outgoing packets through a dangling pointer to the underlying transport. Clearing SctpTransport before DtlsTransport removes the pointer to the underlying transport before it becomes invalid. This fixes a crash in chromium's web platform tests (see https://chromium-review.googlesource.com/c/chromium/src/+/1776711). Original change's description: > Refactor SCTP data channels to use DataChannelTransportInterface. > > This change moves SctpTransport to be owned by JsepTransport, which now > holds a DataChannelTransport implementation for SCTP when it is used for > data channels. > > This simplifies negotiation and fallback to SCTP. Negotiation can now > use a composite DataChannelTransport, just as negotiation for RTP uses a > composite RTP transport. > > PeerConnection also has one fewer way it needs to manage data channels. > It now handles SCTP and datagram- or media-transport-based data channels > the same way. > > There are a few leaky abstractions left. For example, PeerConnection > calls Start() on the SctpTransport at a particular point in negotiation, > but does not need to call this for other transports. Similarly, PC > exposes an interface to the SCTP transport directly to the user; there > is no equivalent for other transports. Bug: webrtc:9719 Change-Id: I64e94b88afb119fdbf5f22750f88c8a084d53937 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151981 Reviewed-by: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Commit-Queue: Benjamin Wright <benwright@webrtc.org> Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29120}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc
- Coding style guide
- Code of conduct