c88b5d56ad
Reason for revert: Fixing errors for reland. I have tested that this does not make Chromium video quality tests fail. Original issue's description: > Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ ) > > Reason for revert: > Fails video quality tests in Chrome: http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568 > I should have looked more closer at those :( > > Original issue's description: > > PyLint fixes for tools-webrtc and webrtc/tools > > > > Fix a lot of errors before bringing in the new config in > > https://codereview.webrtc.org/2737963003/ > > > > BUG=webrtc:7303 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2736233003 > > Cr-Commit-Position: refs/heads/master@{#17137} > > Committed:f5318e1f39> > TBR=oprypin@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7303 > > Review-Url: https://codereview.webrtc.org/2737233003 > Cr-Commit-Position: refs/heads/master@{#17142} > Committed:94f4d9effcNOTRY=true BUG=webrtc:7312 Review-Url: https://codereview.webrtc.org/2741733003 Cr-Commit-Position: refs/heads/master@{#17541}
This file explains how to get the dependencies needed for the barcode tools. barcode_encoder.py ================== This script depends on: * Zxing (Java version) * Ant (must be installed manually) * Java To automatically download Zxing for the encoder script, checkout this directory as a separate gclient solution, like this: gclient config http://webrtc.googlecode.com/svn/trunk/webrtc/tools/barcode_tools gclient sync Then the Zxing Java source code will be put in third_party/zxing. In order to run barcode_encoder.py you then need to build: * zxing/core/core.jar * zxing/javase/javase.jar These are compiled using Ant by running build_zxing.py: python build_zxing.py For more info about Zxing, see https://code.google.com/p/zxing/ barcode_decoder.py ================== This script depends on: * Zxing (C++ version). You need to checkout from Subversion and build the libs and zxing SCons targets. SVN URL: http://zxing.googlecode.com/svn/trunk/cpp * FFMPEG fmpeg 0.11.1 These dependencies must be precompiled separately before running the script. Make sure to add FFMPEG to the PATH environment variable and provide the path to the zxing executable using the mandatory command line flag to the script.