webrtc_m130

History

aleloi 1655e45d85 Elimiteted race condition in the AudioMixer.

The mixer allocates an audio frame for each added data source. This
audio frame was deallocated when a source was removed from the
mixer. Source removal could happen during the mixing, and the existing
locking scheme (and the Clang thread checker) was not sufficient to
prevent a data race.

After this change, the mixer doesn't release its lock until it is
finished with the sources' Audio frames. Since multi-threaded access to
the mixer only happens when a source is added or removed, we believe
that this change wouldn't have any noticeable performance impact.

NOTRY=True

BUG=webrtc:6346

Review-Url: https://codereview.webrtc.org/2439283002
Cr-Commit-Position: refs/heads/master@{#14744}

2016-10-24 13:57:03 +00:00

audio_frame_manipulator_unittest.cc

Changed ramping functionality of the AudioMixer.

2016-10-12 09:15:08 +00:00

audio_frame_manipulator.cc

Split audio mixer into interface and implementation.

2016-10-20 12:06:44 +00:00

audio_frame_manipulator.h

Split audio mixer into interface and implementation.

2016-10-20 12:06:44 +00:00

audio_mixer_impl_unittest.cc

Move audio frame memory handling inside AudioMixer.