Markus Handell
bd933ee29a
SdpOfferAnswerHandler: Significantly reduce audio impairment.
...
It was found from Chrome tracing that worker packet progression in
https://webrtc.github.io/samples/src/content/peerconnection/negotiate-timing/
during renegotiation of 100 transceivers is hindered by a multi-hundred
millisecond Invoke from the signaling to the worker thread. This
causes audio impairment.
Fix this by splitting the single Invoke into a series of Invokes,
allowing packets received during the renegotiation to be processed
between the worker invocations.
Experimental data of negotiation from 1 to 100 video transceivers
WebRtcDistinctWorkerThread OFF, before change:
4415.60 milliseconds, audio impairment 29760
4216.00 milliseconds, audio impairment 25560
4298.40 milliseconds, audio impairment 25440
WebRtcDistinctWorkerThread OFF, after change:
4258.70 milliseconds, audio impairment 26280
4255.50 milliseconds, audio impairment 25920
4363.10 milliseconds, audio impairment 25200
WebRtcDistinctWorkerThread ON, before change:
4407.80 milliseconds, audio impairment 24840
4541.00 milliseconds, audio impairment 26160
4377.80 milliseconds, audio impairment 17040
WebRtcDistinctWorkerThread ON, after change:
4364.80 milliseconds, audio impairment 0
4174.30 milliseconds, audio impairment 0
4309.00 milliseconds, audio impairment 0
We should reconsider this split after lazy decoders and decoder stream
projects have shipped, see
- bugs.webrtc.org/12462
- crbug.com/1157227
- crbug.com/1187289
Bug: webrtc:12840, webrtc:12462, chromium:1157227, chromium:1187289
Change-Id: I8e3b3943bd76f09da74b457690799415335b51f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221103
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34202}
2021-06-02 15:15:04 +00:00
..
2021-05-26 11:53:07 +00:00
2021-04-27 17:01:59 +00:00
2021-05-27 09:56:42 +00:00
2021-05-27 09:56:42 +00:00
2021-05-27 09:56:42 +00:00
2021-05-24 16:17:35 +00:00
2021-05-24 16:17:35 +00:00
2021-06-01 06:57:31 +00:00
2021-05-04 13:52:35 +00:00
2021-04-19 15:59:20 +00:00
2021-04-16 13:10:54 +00:00
2021-04-21 10:16:43 +00:00
2021-05-07 18:01:54 +00:00
2021-05-26 09:42:09 +00:00
2021-05-26 09:42:09 +00:00
2021-05-25 18:14:43 +00:00
2021-04-21 07:04:01 +00:00
2021-05-10 10:31:48 +00:00
2021-05-10 10:31:48 +00:00
2021-05-21 20:50:48 +00:00
2021-05-10 10:31:48 +00:00
2021-04-19 19:32:23 +00:00
2021-04-19 19:32:23 +00:00
2019-01-28 11:17:00 +00:00
2020-03-21 18:53:46 +00:00
2021-05-21 21:45:29 +00:00
2021-05-21 21:45:29 +00:00
2021-04-27 17:01:59 +00:00
2021-05-21 21:45:29 +00:00
2021-05-21 21:45:29 +00:00
2021-04-26 11:05:19 +00:00
2021-04-27 17:01:59 +00:00
2021-05-28 06:53:29 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-11-27 11:08:10 +00:00
2021-01-29 16:14:10 +00:00
2019-04-02 10:13:36 +00:00
2021-04-27 17:01:59 +00:00
2021-02-10 15:04:55 +00:00
2021-02-10 15:04:55 +00:00
2021-05-17 14:37:55 +00:00
2021-05-17 14:37:55 +00:00
2021-05-17 14:37:55 +00:00
2021-01-05 12:55:24 +00:00
2021-01-05 12:55:24 +00:00
2021-01-05 12:55:24 +00:00
2021-05-21 21:45:29 +00:00
2021-05-26 09:42:09 +00:00
2021-04-27 05:53:37 +00:00
2021-04-27 17:01:59 +00:00
2021-04-27 17:01:59 +00:00
2021-02-10 15:04:55 +00:00
2019-01-11 17:11:39 +00:00
2021-04-27 17:01:59 +00:00
2019-01-25 20:29:58 +00:00
2021-01-29 16:14:10 +00:00
2019-05-13 18:37:47 +00:00
2021-05-26 09:42:09 +00:00
2021-05-26 09:42:09 +00:00
2021-04-19 19:32:23 +00:00
2019-01-29 02:33:50 +00:00
2019-01-25 20:29:58 +00:00
2021-05-28 06:53:29 +00:00
2021-05-28 06:53:29 +00:00
2020-05-18 17:06:25 +00:00
2021-04-27 17:01:59 +00:00
2020-09-10 13:11:44 +00:00
2020-02-25 14:45:04 +00:00
2021-04-27 17:01:59 +00:00
2021-05-27 09:56:42 +00:00
2021-04-27 17:01:59 +00:00
2021-05-27 09:56:42 +00:00
2021-01-20 10:51:07 +00:00
2021-05-28 06:53:29 +00:00
2019-07-08 13:45:15 +00:00
2021-06-01 06:57:31 +00:00
2021-06-01 06:57:31 +00:00
2021-05-12 17:06:58 +00:00
2021-05-27 09:56:42 +00:00
2021-05-27 09:56:42 +00:00
2021-04-27 17:01:59 +00:00
2021-04-27 17:01:59 +00:00
2021-04-19 16:22:23 +00:00
2021-04-15 10:20:00 +00:00
2021-05-18 09:10:27 +00:00
2021-02-10 15:04:55 +00:00
2021-01-29 16:14:10 +00:00
2021-05-28 06:53:29 +00:00
2021-05-10 08:47:48 +00:00
2021-04-27 17:01:59 +00:00
2021-05-27 09:56:42 +00:00
2021-04-30 18:55:47 +00:00
2021-05-26 09:43:29 +00:00
2019-10-14 12:40:53 +00:00
2021-05-31 10:34:09 +00:00
2021-05-26 09:43:29 +00:00
2021-05-28 06:53:29 +00:00
2021-05-28 06:53:29 +00:00
2021-05-28 06:53:29 +00:00
2021-05-17 14:37:55 +00:00
2021-04-08 06:39:22 +00:00
2021-05-31 21:39:37 +00:00
2021-05-31 21:39:37 +00:00
2021-04-23 08:40:35 +00:00
2021-05-31 21:39:37 +00:00
2019-04-09 17:18:20 +00:00
2021-03-23 18:44:12 +00:00
2019-01-25 20:29:58 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-08-11 10:46:23 +00:00
2021-01-29 16:14:10 +00:00
2020-01-09 09:28:07 +00:00
2021-01-29 16:14:10 +00:00
2020-01-09 09:28:07 +00:00
2021-05-28 06:53:29 +00:00
2021-05-27 09:56:42 +00:00
2021-05-17 14:37:55 +00:00
2021-05-28 06:53:29 +00:00
2021-05-17 14:37:55 +00:00
2021-04-27 17:01:59 +00:00
2021-01-29 16:14:10 +00:00
2021-05-17 14:37:55 +00:00
2021-05-17 14:37:55 +00:00
2021-05-28 06:53:29 +00:00
2021-05-17 14:37:55 +00:00
2021-02-10 15:04:55 +00:00
2019-05-24 23:58:46 +00:00
2020-03-20 16:55:38 +00:00
2021-05-05 16:22:33 +00:00
2021-01-29 16:14:10 +00:00
2021-05-10 10:31:48 +00:00
2021-01-29 16:14:10 +00:00
2021-05-28 06:53:29 +00:00
2021-05-10 10:31:48 +00:00
2021-05-21 21:45:29 +00:00
2021-05-21 21:45:29 +00:00
2021-05-21 21:45:29 +00:00
2021-01-11 11:31:33 +00:00
2021-05-10 10:31:48 +00:00
2021-05-10 10:31:48 +00:00
2021-06-02 15:15:04 +00:00
2021-04-27 05:53:37 +00:00
2019-07-08 13:45:15 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2020-10-26 10:22:46 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-04-16 13:10:54 +00:00
2021-04-27 05:53:37 +00:00
2021-05-26 09:42:09 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2019-07-08 13:45:15 +00:00
2021-04-12 07:57:03 +00:00
2021-02-10 15:04:55 +00:00
2020-07-16 13:52:28 +00:00
2021-04-12 07:57:03 +00:00
2021-03-08 08:50:09 +00:00
2019-09-17 15:47:29 +00:00
2021-01-29 16:14:10 +00:00
2019-07-08 13:45:15 +00:00
2020-10-05 12:41:23 +00:00
2021-04-27 17:01:59 +00:00
2021-05-17 14:37:55 +00:00
2021-04-19 16:22:23 +00:00
2021-04-27 17:01:59 +00:00
2021-05-24 16:17:35 +00:00
2021-01-29 16:14:10 +00:00
2021-01-29 16:14:10 +00:00
2021-04-20 06:44:40 +00:00
2021-04-20 06:44:40 +00:00
2019-02-05 15:12:20 +00:00
2021-05-21 21:45:29 +00:00
2020-10-09 08:29:45 +00:00
2021-01-29 16:14:10 +00:00
2019-09-24 08:56:24 +00:00
2021-05-26 10:04:29 +00:00
2021-05-17 14:37:55 +00:00
2021-05-24 16:17:35 +00:00
2021-05-27 09:56:42 +00:00
2021-04-27 17:01:59 +00:00
2021-01-29 16:14:10 +00:00
2021-02-16 12:41:35 +00:00
2021-05-27 09:56:42 +00:00
2021-05-28 06:53:29 +00:00
2021-05-24 16:17:35 +00:00
2021-02-10 15:04:55 +00:00
2021-04-27 17:01:59 +00:00
2021-05-24 16:17:35 +00:00
2021-05-24 16:17:35 +00:00
2021-04-27 05:53:37 +00:00
2021-04-27 05:53:37 +00:00
2021-01-29 16:14:10 +00:00
2021-04-27 17:01:59 +00:00
2021-01-29 16:14:10 +00:00