4319b1695e
This reverts commit 8c2250eddc7263036397179a0794b9b17d7afb38. Reason for revert: breaks downstream project Original change's description: > Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in c++ code > > Bug: webrtc:12336 > Change-Id: If76f00d0883b5c8a90d3ef5554f5e22384b3fb58 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/197620 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32978} TBR=danilchap@webrtc.org,mbonadei@webrtc.org,crodbro@webrtc.org Change-Id: I5c9d419785254878a825865808b56841cd30b9b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:12336 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201731 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32979}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.