Reason for revert:
This seems to be causing some video freezes. See https://bugs.chromium.org/p/webrtc/issues/detail?id=8251
Original issue's description:
> Completed the functionalities of SrtpTransport.
>
> The SrtpTransport takes the SRTP responsibilities from the BaseChannel
> and SrtpFilter. SrtpTransport is now responsible for setting the crypto
> keys, protecting and unprotecting the packets. SrtpTransport doesn't know
> if the keys are from SDES or DTLS handshake.
>
> BaseChannel is now only responsible setting the offer/answer for SDES
> or extracting the key from DtlsTransport and configuring the
> SrtpTransport.
>
> SrtpFilter is used by BaseChannel as a helper for SDES negotiation.
>
> BUG=webrtc:7013
>
> Review-Url: https://codereview.webrtc.org/2997983002
> Cr-Commit-Position: refs/heads/master@{#19636}
> Committed: e683c6871f
TBR=deadbeef@webrtc.org,pthatcher@google.com,zhihuang@webrtc.org
Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7013
Review-Url: https://codereview.webrtc.org/3018513002
Cr-Commit-Position: refs/heads/master@{#19895}
63 lines
2.1 KiB
C++
63 lines
2.1 KiB
C++
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "pc/srtptransport.h"
|
|
|
|
#include <string>
|
|
|
|
#include "media/base/rtputils.h"
|
|
#include "pc/rtptransport.h"
|
|
#include "pc/srtpsession.h"
|
|
#include "rtc_base/asyncpacketsocket.h"
|
|
#include "rtc_base/copyonwritebuffer.h"
|
|
#include "rtc_base/ptr_util.h"
|
|
#include "rtc_base/trace_event.h"
|
|
|
|
namespace webrtc {
|
|
|
|
SrtpTransport::SrtpTransport(bool rtcp_mux_enabled,
|
|
const std::string& content_name)
|
|
: content_name_(content_name),
|
|
rtp_transport_(rtc::MakeUnique<RtpTransport>(rtcp_mux_enabled)) {
|
|
ConnectToRtpTransport();
|
|
}
|
|
|
|
SrtpTransport::SrtpTransport(std::unique_ptr<RtpTransportInternal> transport,
|
|
const std::string& content_name)
|
|
: content_name_(content_name), rtp_transport_(std::move(transport)) {
|
|
ConnectToRtpTransport();
|
|
}
|
|
|
|
void SrtpTransport::ConnectToRtpTransport() {
|
|
rtp_transport_->SignalPacketReceived.connect(
|
|
this, &SrtpTransport::OnPacketReceived);
|
|
rtp_transport_->SignalReadyToSend.connect(this,
|
|
&SrtpTransport::OnReadyToSend);
|
|
}
|
|
|
|
bool SrtpTransport::SendPacket(bool rtcp,
|
|
rtc::CopyOnWriteBuffer* packet,
|
|
const rtc::PacketOptions& options,
|
|
int flags) {
|
|
// TODO(zstein): Protect packet.
|
|
|
|
return rtp_transport_->SendPacket(rtcp, packet, options, flags);
|
|
}
|
|
|
|
void SrtpTransport::OnPacketReceived(bool rtcp,
|
|
rtc::CopyOnWriteBuffer* packet,
|
|
const rtc::PacketTime& packet_time) {
|
|
// TODO(zstein): Unprotect packet.
|
|
|
|
SignalPacketReceived(rtcp, packet, packet_time);
|
|
}
|
|
|
|
} // namespace webrtc
|