62995db2fc
In preparation for switching the default from kPlanB to kUnifiedPlan, which could cause subtle bugs for those not prepared for it, we change the default to kNotSpecified. The only purpose of kNotSpecified is to crash, forcing any dependencies to explicitly set their sdp_semantics value. Tests are updated to explicitly set sdp_semantics when necessary, and where the test does not care we update to kUnifiedPlan. If this change lands without getting reverted we can let it sit for a few weeks, after which we should change the default to kUnifiedPlan and delete kNotSpecified. Bug: webrtc:11121 Change-Id: I19b669b0735d78e269e19eaae86c2d7d95a91141 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242968 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35651}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.