3f0bc2c176
This reverts commit 2a11b2451a4068746fa0c55fa210efd4a15e4423. Reason for revert: Causes b/147826709 Original change's description: > Enable using a custom NetEqFactory in simulations > > Bug: webrtc:11005 > Change-Id: I8a15f77953cbd3c29a75c7cfc77f926b138994b9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165580 > Commit-Queue: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30286} TBR=kwiberg@webrtc.org,ivoc@webrtc.org Change-Id: I14a0bd6ad2a90f1686b8b1a78f18aea9325871fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11005 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166403 Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Sandeep Siddhartha <sansid@google.com> Cr-Commit-Position: refs/heads/master@{#30288}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.