3d622d6e5c
This reverts commit 4d6795f828bc4f2b050405b0ff73d4020b2a2963. Reason for revert: chromium:961253 Original change's description: > Refactor handling of configuration overrides from Vp8FrameBufferController > > Make Vp8FrameBufferController::UpdateConfiguration return a set > of desired overrides. These overrides are cumulative with > previously returned override sets. > > Bug: webrtc:10382 > Change-Id: I1aa9544ae0cf6c57115e80963b3bbcdc3101db5e > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134649 > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Commit-Queue: Elad Alon <eladalon@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27835} TBR=brandtr@webrtc.org,eladalon@webrtc.org,sprang@webrtc.org Bug: chromium:961253 Change-Id: I06f0eafd4f38c441ddbdfeebae8055b02465eb9b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135940 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27900}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.