webrtc_m130

History

nisse 3011627142 Revert of Update test code to use I420Buffer when writing pixel data. (patchset #2 id:140001 of https://codereview.webrtc.org/2342783003/ )

Reason for revert:
I was too impatient; this made android builds fail instead. See https://build.chromium.org/p/client.webrtc/builders/Linux32%20ARM/builds/585/steps/compile/logs/stdio

Original issue's description:
> Reland of Update test code to use I420Buffer when writing pixel data. (patchset #1 id:1 of https://codereview.webrtc.org/2342123003/ )
>
> Reason for revert:
> Intending to fix problem and reland.
>
> Original issue's description:
> > Revert of Update test code to use I420Buffer when writing pixel data. (patchset #5 id:80001 of https://codereview.webrtc.org/2333373007/ )
> >
> > Reason for revert:
> > Fails 64-bit windows builds, it turns out I missed some of the needed int/size_t casts. Example https://build.chromium.org/p/client.webrtc/waterfall?builder=Win64%20Release
> >
> > Hope our windows try bots get back in working shape soon.
> >
> > Original issue's description:
> > > Update test code to use I420Buffer when writing pixel data.
> > >
> > > VideoFrameBuffer and VideoFrame will become immutable.
> > >
> > > BUG=webrtc:5921
> > > R=magjed@webrtc.org, phoglund@webrtc.org
> > >
> > > Committed: https://crrev.com/280ad1514e44bf6717e5871526dd4632f759eb3d
> > > Cr-Commit-Position: refs/heads/master@{#14249}
> >
> > TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:5921
> >
> > Committed: https://crrev.com/fbf14607267adf03d235273283ca452a1e564861
> > Cr-Commit-Position: refs/heads/master@{#14251}
>
> TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5921
>
> Committed: https://crrev.com/d21534a8cfe636bbcf3d7bb151945590abc92b2a
> Cr-Commit-Position: refs/heads/master@{#14258}

TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5921

Review-Url: https://codereview.webrtc.org/2343083002
Cr-Commit-Position: refs/heads/master@{#14259}