3c589beee6
This is a reland of 184f6d5d75c198cb7b70b8f9b75e0b5096c6e577. Incorrect build dependencies in downstream tests have been fixed, and an initialization bug in this CL has also been fixed. Original change's description: > Change clip_name -> clip_path in VideoQualityTestFixture::Params::Video. > > This allows external users of this test fixture to specify a custom > path, rather than just a custom file name. > > Bug: webrtc:10349 > Change-Id: I84e886c8bc28583017ce9ed7b9e7ee6a8e95730f > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126227 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Åsa Persson <asapersson@webrtc.org> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27033} TBR: kwiberg@webrtc.org Bug: webrtc:10349 Change-Id: I0ec9dd26cd96c3db8ac8482893a26e62a1b1eefc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127181 Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27102}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.