3b8ed28d72
This reverts commit 9469c784dbf732472e3b2a60a5fcca0a2f432313. Reason for revert: Breaks downstream projects. Original change's description: > Added OnIceCandidateError to API and implementation > > Bug: webrtc:3098 > Change-Id: I27ffd015ebf9e8130c1288f7331b0e2fdafb01ef > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135953 > Commit-Queue: Steve Anton <steveanton@webrtc.org> > Reviewed-by: Amit Hilbuch <amithi@webrtc.org> > Reviewed-by: Qingsi Wang <qingsi@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28173} TBR=steveanton@webrtc.org,hbos@webrtc.org,qingsi@webrtc.org,amithi@webrtc.org,elrello@microsoft.com Change-Id: I3d77242ca3556cb491f523c238fbc7d3e294839b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:3098 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140620 Reviewed-by: Yves Gerey <yvesg@google.com> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#28177}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.