admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Henrik Boström 0a16276290 Restore FiredDirection and maybe fire OnTrack in Rollback. 
Prior to this CL, rollback did not restore FiredDirection and remote
streams were only sometimes restored. This resulted in not firing
ontrack if a track was rolled back and then added again on the same
transceiver.

Rollback also never performed OnTrack, which is incorrect because a
transceiver that goes from sendrecv to inactive will cause OnRemoveTrack
and if this is rolled back (so we become sendrecv again) then we need
OnTrack to fire.

This CL improves rollback's "memory", fires ontrack in Rollback() and
adds test coverage.

Needed to solve similar bugs in the Chromium layers as well:
https://chromium-review.googlesource.com/c/chromium/src/+/3613313

Bug: chromium:1320669
Change-Id: I655dd7d8a6b86080fe0e7c32c9e8c6434062ae91
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260330
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36734}
2022-05-02 18:07:24 +00:00
..
g3doc
Remove usrsctp, dcSCTP is now the unique SCTP implementation
2022-04-04 10:30:46 +00:00
scenario_tests
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
test
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
audio_rtp_receiver_unittest.cc
Make sure OnChanged() notifications are handled, post construction.
2022-03-22 14:04:04 +00:00
audio_rtp_receiver.cc
[Rollback] Don't end tracks when transceiver is still in use.
2022-04-27 11:57:52 +00:00
audio_rtp_receiver.h
[Rollback] Don't end tracks when transceiver is still in use.
2022-04-27 11:57:52 +00:00
audio_track.cc
Add several thread checks to RtpSender classes.
2022-02-17 09:00:54 +00:00
audio_track.h
Reland "Move VideoTrackSourceProxy creation into VideoTrack."
2022-02-22 11:14:15 +00:00
BUILD.gn
Move pc/channel.h to only be used in .cc files
2022-04-27 17:13:11 +00:00
channel_interface.h
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
channel_manager_unittest.cc
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
channel_manager.cc
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
channel_manager.h
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
channel_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 3/inf
2022-03-11 07:46:34 +00:00
channel.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
channel.h
Apply include reduction to channel.h and channel_manager.h
2022-03-17 12:13:04 +00:00
connection_context.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 16/inf
2022-04-20 06:35:27 +00:00
connection_context.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 16/inf
2022-04-20 06:35:27 +00:00
data_channel_controller.cc
Delete unused method FindDataChannelBySid
2022-04-19 19:41:37 +00:00
data_channel_controller.h
Delete unused method FindDataChannelBySid
2022-04-19 19:41:37 +00:00
data_channel_integrationtest.cc
Fix SdpSemantics::kPlanB deprecated usage
2022-04-06 09:35:03 +00:00
data_channel_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
data_channel_utils.cc
…
data_channel_utils.h
…
DEPS
…
dtls_srtp_transport_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 1
2022-03-09 13:23:21 +00:00
dtls_srtp_transport.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
dtls_srtp_transport.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
dtls_transport_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
dtls_transport.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
dtls_transport.h
…
dtmf_sender_unittest.cc
…
dtmf_sender.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
dtmf_sender.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
external_hmac.cc
…
external_hmac.h
Break out a few more targets from rtc_pc_base
2022-03-10 18:36:43 +00:00
ice_server_parsing_unittest.cc
…
ice_server_parsing.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
ice_server_parsing.h
…
ice_transport_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
ice_transport.cc
…
ice_transport.h
Break out a few more targets from rtc_pc_base
2022-03-10 18:36:43 +00:00
jitter_buffer_delay_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
jitter_buffer_delay.cc
…
jitter_buffer_delay.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
jsep_ice_candidate.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
jsep_session_description_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
jsep_session_description.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
jsep_transport_collection.cc
Reland "Fix bug where we assume new m= sections will always be bundled."
2021-08-11 23:36:28 +00:00
jsep_transport_collection.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
jsep_transport_controller_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 1
2022-03-09 13:23:21 +00:00
jsep_transport_controller.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 8/inf
2022-03-17 09:08:45 +00:00
jsep_transport_controller.h
Move pc/channel.h to only be used in .cc files
2022-04-27 17:13:11 +00:00
jsep_transport_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 1
2022-03-09 13:23:21 +00:00
jsep_transport.cc
stats: add dtlsRole to transport
2022-05-02 10:13:54 +00:00
jsep_transport.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN more.
2022-01-20 11:00:18 +00:00
local_audio_source_unittest.cc
…
local_audio_source.cc
…
local_audio_source.h
…
media_protocol_names.cc
Cleanup: Move some more protocol names into media_protocol_names
2021-11-02 11:51:31 +00:00
media_protocol_names.h
Cleanup: Move some more protocol names into media_protocol_names
2021-11-02 11:51:31 +00:00
media_session_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
media_session.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
media_session.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
media_stream_observer.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
media_stream_observer.h
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
media_stream_proxy.h
Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument
2022-04-21 12:32:17 +00:00
media_stream_track_proxy.h
Move VideoTrack's content_hint property to the signaling thread.
2022-02-15 21:55:59 +00:00
media_stream_unittest.cc
Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument
2022-04-21 12:32:17 +00:00
media_stream.cc
Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument
2022-04-21 12:32:17 +00:00
media_stream.h
Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument
2022-04-21 12:32:17 +00:00
OWNERS
Remove inactive owners.
2021-08-31 14:27:49 +00:00
peer_connection_adaptation_integrationtest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_bundle_unittest.cc
Delete old versions of GetNetworks and GetAnyAddressNetworks
2022-04-07 11:25:12 +00:00
peer_connection_crypto_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_data_channel_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_end_to_end_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_factory_proxy.h
…
peer_connection_factory_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_factory.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 16/inf
2022-04-20 06:35:27 +00:00
peer_connection_factory.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 16/inf
2022-04-20 06:35:27 +00:00
peer_connection_header_extension_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_histogram_unittest.cc
Prepare for deletion of implicit conversion from rtc::scoped_refptr<T> to T*
2022-04-28 12:58:56 +00:00
peer_connection_ice_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_integrationtest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_interface_unittest.cc
Reland "remove mslabel and mslabel ssrc-specific attributes"
2022-04-25 08:50:50 +00:00
peer_connection_internal.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 16/inf
2022-04-20 06:35:27 +00:00
peer_connection_jsep_unittest.cc
Restore FiredDirection and maybe fire OnTrack in Rollback.
2022-05-02 18:07:24 +00:00
peer_connection_media_unittest.cc
Remove calls to deprecated CreatePC() and CreateDC()
2022-04-06 11:57:50 +00:00
peer_connection_message_handler.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_message_handler.h
…
peer_connection_proxy.h
Deprecate RemoveTrack (old signature)
2022-01-04 20:44:07 +00:00
peer_connection_rampup_tests.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_rtp_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_signaling_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_simulcast_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_wrapper.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
peer_connection_wrapper.h
…
peer_connection.cc
Eliminate channel.h from peer_connection.cc
2022-05-02 09:04:32 +00:00
peer_connection.h
Separate setting a cricket::Channel from clearing the channel.
2022-04-28 14:19:16 +00:00
proxy_unittest.cc
Make RtpTransceiver not inherit from RefCountedObject.
2022-03-18 16:17:24 +00:00
proxy.cc
…
proxy.h
Make RtpTransceiver not inherit from RefCountedObject.
2022-03-18 16:17:24 +00:00
remote_audio_source.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
remote_audio_source.h
Move pc/channel.h to only be used in .cc files
2022-04-27 17:13:11 +00:00
rtc_stats_collector_unittest.cc
stats: implement inbound-rtp totalProcessingDelay for video
2022-05-02 10:56:22 +00:00
rtc_stats_collector.cc
stats: implement inbound-rtp totalProcessingDelay for video
2022-05-02 10:56:22 +00:00
rtc_stats_collector.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtc_stats_integrationtest.cc
stats: implement inbound-rtp totalProcessingDelay for video
2022-05-02 10:56:22 +00:00
rtc_stats_traversal_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtc_stats_traversal.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
rtc_stats_traversal.h
…
rtcp_mux_filter_unittest.cc
…
rtcp_mux_filter.cc
Reland "Modify Bundle logic to not add & destroy extra transport at add-track"
2021-08-11 21:50:08 +00:00
rtcp_mux_filter.h
…
rtp_media_utils_unittest.cc
…
rtp_media_utils.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
rtp_media_utils.h
Break out a few more targets from rtc_pc_base
2022-03-10 18:36:43 +00:00
rtp_parameters_conversion_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_parameters_conversion.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_parameters_conversion.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_receiver_proxy.h
…
rtp_receiver.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_receiver.h
[Rollback] Don't end tracks when transceiver is still in use.
2022-04-27 11:57:52 +00:00
rtp_sender_proxy.h
…
rtp_sender_receiver_unittest.cc
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
rtp_sender.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
rtp_sender.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_transceiver_unittest.cc
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
rtp_transceiver.cc
Restore FiredDirection and maybe fire OnTrack in Rollback.
2022-05-02 18:07:24 +00:00
rtp_transceiver.h
Restore FiredDirection and maybe fire OnTrack in Rollback.
2022-05-02 18:07:24 +00:00
rtp_transmission_manager.cc
Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument
2022-04-21 12:32:17 +00:00
rtp_transmission_manager.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_transport_internal.h
…
rtp_transport_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_transport.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
rtp_transport.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sctp_data_channel_transport.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sctp_data_channel_transport.h
…
sctp_data_channel.cc
Make RtpTransceiver not inherit from RefCountedObject.
2022-03-18 16:17:24 +00:00
sctp_data_channel.h
datachannel: Remove buffered_amount_ variable
2021-10-18 13:32:22 +00:00
sctp_transport_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sctp_transport.cc
…
sctp_transport.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sctp_utils_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sctp_utils.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sctp_utils.h
…
sdp_offer_answer_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
sdp_offer_answer.cc
Restore FiredDirection and maybe fire OnTrack in Rollback.
2022-05-02 18:07:24 +00:00
sdp_offer_answer.h
Move ownership of the Channel class to RTCRtpTransceiver
2022-04-30 19:21:11 +00:00
sdp_serializer_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sdp_serializer.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sdp_serializer.h
…
sdp_state_provider.h
…
sdp_utils.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
sdp_utils.h
…
session_description_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
session_description.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
session_description.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
simulcast_description.cc
Introduce a variant of rtc::split that returns a vector of string_view
2022-01-25 08:25:50 +00:00
simulcast_description.h
Introduce a variant of rtc::split that returns a vector of string_view
2022-01-25 08:25:50 +00:00
srtp_filter_unittest.cc
Revert "Remove code supporting the SDES crypto mode in SDP"
2021-11-04 14:46:27 +00:00
srtp_filter.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
srtp_filter.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
srtp_session_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 1
2022-03-09 13:23:21 +00:00
srtp_session.cc
Move global libsrtp usage count into a singleton class
2022-04-06 07:41:52 +00:00
srtp_session.h
Move global libsrtp usage count into a singleton class
2022-04-06 07:41:52 +00:00
srtp_transport_unittest.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 1
2022-03-09 13:23:21 +00:00
srtp_transport.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
srtp_transport.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
stats_collector_interface.h
…
stats_collector_unittest.cc
Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument
2022-04-21 12:32:17 +00:00
stats_collector.cc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
stats_collector.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
2022-03-29 10:14:00 +00:00
stream_collection.h
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
track_media_info_map_unittest.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
track_media_info_map.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
track_media_info_map.h
…
transceiver_list.cc
Restore FiredDirection and maybe fire OnTrack in Rollback.
2022-05-02 18:07:24 +00:00
transceiver_list.h
Restore FiredDirection and maybe fire OnTrack in Rollback.
2022-05-02 18:07:24 +00:00
transport_stats.cc
…
transport_stats.h
stats: add dtlsRole to transport
2022-05-02 10:13:54 +00:00
usage_pattern.cc
…
usage_pattern.h
…
used_ids_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
used_ids.h
Remove frequent log.
2022-01-18 13:46:37 +00:00
video_rtp_receiver_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
video_rtp_receiver.cc
[Rollback] Don't end tracks when transceiver is still in use.
2022-04-27 11:57:52 +00:00
video_rtp_receiver.h
[Rollback] Don't end tracks when transceiver is still in use.
2022-04-27 11:57:52 +00:00
video_rtp_track_source_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
video_rtp_track_source.cc
…
video_rtp_track_source.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN more.
2022-01-20 11:00:18 +00:00
video_track_source_proxy.cc
Make RtpTransceiver not inherit from RefCountedObject.
2022-03-18 16:17:24 +00:00
video_track_source_proxy.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
video_track_source.cc
Reland "Remove stopped_ from AudioRtpReceiver and VideoRtpReceiver."
2022-02-09 16:54:06 +00:00
video_track_source.h
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
video_track_unittest.cc
Update IWYU tool with a mapping file
2022-02-24 11:05:06 +00:00
video_track.cc
Update VideoTrack::Create to use rtc::scoped_refptr.
2022-03-21 10:38:52 +00:00
video_track.h
Update VideoTrack::Create to use rtc::scoped_refptr.
2022-03-21 10:38:52 +00:00
webrtc_sdp_unittest.cc
Reland "remove mslabel and mslabel ssrc-specific attributes"
2022-04-25 08:50:50 +00:00
webrtc_sdp.cc
Reland "remove mslabel and mslabel ssrc-specific attributes"
2022-04-25 08:50:50 +00:00
webrtc_sdp.h
…
webrtc_session_description_factory.cc
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
2022-04-20 13:18:33 +00:00
webrtc_session_description_factory.h
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 16/inf
2022-04-20 06:35:27 +00:00