andrew@webrtc.org 382c0c209d Allow the RTP level indicator computation to work at any sample rate.
Break out the computation to a separate class, and call directly into
this from channel.cc rather than going through AudioProcessing. This
circumvents AudioProcessing's sample rate limitations.

We now compute the RMS over all samples rather than downmixing to a
single channel. This makes the call point in channel.cc easier, is
more "correct" and should have similar (negligible) complexity.

This caused slight changes in the RMS output, so the ApmTest.Process
reference has been updated. Snippet of the failing output:

[ RUN      ] ApmTest.Process
Running test 4 of 12...
Value of: rms_level
  Actual: 27
Expected: test->rms_level()
Which is: 28
Running test 5 of 12...
Value of: rms_level
  Actual: 26
Expected: test->rms_level()
Which is: 27
Running test 6 of 12...
Value of: rms_level
  Actual: 26
Expected: test->rms_level()
Which is: 27
Running test 10 of 12...
Value of: rms_level
  Actual: 27
Expected: test->rms_level()
Which is: 28
Running test 11 of 12...
Value of: rms_level
  Actual: 26
Expected: test->rms_level()
Which is: 27
Running test 12 of 12...
Value of: rms_level
  Actual: 26
Expected: test->rms_level()
Which is: 27

BUG=3290
TESTED=Chrome assert is avoided and both voe_cmd_test and apprtc
produce reasonable printed out results from RMS().

R=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6056 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-05 18:22:21 +00:00

62 lines
1.4 KiB
C++

/*
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "webrtc/modules/audio_processing/rms_level.h"
#include <assert.h>
#include <math.h>
namespace webrtc {
static const float kMaxSquaredLevel = 32768.0 * 32768.0;
RMSLevel::RMSLevel()
: sum_square_(0.0),
sample_count_(0) {}
RMSLevel::~RMSLevel() {}
void RMSLevel::Reset() {
sum_square_ = 0.0;
sample_count_ = 0;
}
void RMSLevel::Process(const int16_t* data, int length) {
for (int i = 0; i < length; ++i) {
sum_square_ += data[i] * data[i];
}
sample_count_ += length;
}
void RMSLevel::ProcessMuted(int length) {
sample_count_ += length;
}
int RMSLevel::RMS() {
if (sample_count_ == 0 || sum_square_ == 0.0) {
Reset();
return kMinLevel;
}
// Normalize by the max level.
float rms = sum_square_ / (sample_count_ * kMaxSquaredLevel);
// 20log_10(x^0.5) = 10log_10(x)
rms = 10 * log10(rms);
assert(rms <= 0);
if (rms < -kMinLevel)
rms = -kMinLevel;
rms = -rms;
Reset();
return static_cast<int>(rms + 0.5);
}
} // namespace webrtc