378b1c6826
This reverts commit 626f87d90501fd8d7a4ea071686cd8befd0d430c. Reason for revert: Breaks one downstream project, will re-land after the dependency stops referencing an unimplemented RTT metric Original change's description: > [Stats] Cleanup: Remove unimplemented metrics and obsolete TODOs. > > In preparation for the spec moving closer to PR, let's not have > placeholder metrics not implemented. > > Bug: webrtc:14167 > Change-Id: If4688ef85b57f88154d490186b306b30414874e4 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265383 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37205} Bug: webrtc:14167 Change-Id: I7e9ac60eb474b44fab678d4c08ddcae846ce456c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265800 Auto-Submit: Henrik Boström <hbos@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37206}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.