I mistakenly ommitted the checks when logging.h was ported from libjingle to webrtc. This caused a significant CPU cost for logs which were later filtered out anyway. Verified with LS_VERBOSE logging in neteq4, running: $ out/Release/modules_unittests \ --gtest_filter=NetEqDecodingTest.TestBitExactness \ --gtest_repeat=50 > time.txt $ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort Results on a MacBook Retina, averaged over 5 runs: Verbose logs disabled: 666 ms Exisiting implementation, verbose logs enabled: 944 ms (1.42x) New implementation, verbose logs enabled: 673 ms (1.01x) BUG=2314 R=henrik.lundin@webrtc.org, henrike@webrtc.org, kjellander@webrtc.org, turaj@webrtc.org Review URL: https://webrtc-codereview.appspot.com/2160005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
44 lines
1.1 KiB
C++
44 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/system_wrappers/interface/trace.h"
|
|
|
|
namespace webrtc {
|
|
|
|
const int Trace::kBoilerplateLength = 71;
|
|
const int Trace::kTimestampPosition = 13;
|
|
const int Trace::kTimestampLength = 12;
|
|
uint32_t Trace::level_filter_ = kTraceNone;
|
|
|
|
void Trace::CreateTrace() {
|
|
}
|
|
|
|
void Trace::ReturnTrace() {
|
|
}
|
|
|
|
int32_t Trace::TraceFile(char file_name[1024]) {
|
|
return -1;
|
|
}
|
|
|
|
int32_t Trace::SetTraceFile(const char* file_name,
|
|
const bool add_file_counter) {
|
|
return -1;
|
|
}
|
|
|
|
int32_t Trace::SetTraceCallback(TraceCallback* callback) {
|
|
return -1;
|
|
}
|
|
|
|
void Trace::Add(const TraceLevel level, const TraceModule module,
|
|
const int32_t id, const char* msg, ...) {
|
|
}
|
|
|
|
} // namespace webrtc
|