09226fc832
Currently the echo canceller reference signal is high-pass filtered to avoid the need of modeling the capture-side high-pass filter as part of the echo path. This can lead to the lowest frequency bins of the linear filter diverging as there is little low-frequency content available for training. Over time the filter can output an increasing amount of low-frequency power, which in turn affects the filter's ability to adapt properly. Disabling the high-pass filtering of the echo canceller reference solves this issue, resulting in improved filter convergence. Bug: webrtc:12265 Change-Id: Ic526a4b1b73e1808cfcd96a8cdee801b96a27671 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208288 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33322}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.