c8895aa2f3
Currently, I420VideoFrame uses three webrtc::Plane to store pixel data, and WebRtcVideoFrame uses WebRtcVideoFrame::FrameBuffer/webrtc::VideoFrame. The two subclasses WebRtcTextureVideoFrame and TextureVideoFrame use a NativeHandle to store pixel data, and there is also a class WebRtcVideoRenderFrame that wraps an I420VideoFrame. This CL replaces these classes with a new interface VideoFrameBuffer that provides the common functionality. This makes it possible to remove deep frame copies between cricket::VideoFrame and I420VideoFrame. Some additional minor changes are: * Disallow creation of 0x0 texture frames. * Remove the half-implemented ref count functions in I420VideoFrame. * Remove the Alias functionality in WebRtcVideoFrame The final goal is to eliminate all frame copies, but to limit the scope of this CL, some planned changes are postponed to follow-up CL:s (see planned changes in https://webrtc-codereview.appspot.com/38879004, or https://docs.google.com/document/d/1bxoJZNmlo-Z9GnQwIaWpEG6hDlL_W-bzka8Zb_K2NbA/preview). Specifically, this CL: * Keeps empty subclasses WebRtcTextureVideoFrame and TextureVideoFrame, and just delegates the construction to the superclass. * Keeps the deep copies from cricket::VideoFrame to I420VideoFrame. BUG=1128 R=mflodman@webrtc.org, pbos@webrtc.org, perkj@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/42469004 Cr-Commit-Position: refs/heads/master@{#8580} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8580 4adac7df-926f-26a2-2b94-8c16560cd09d
30 lines
1007 B
C++
30 lines
1007 B
C++
/*
|
|
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/common_video/interface/texture_video_frame.h"
|
|
|
|
#include "webrtc/base/refcount.h"
|
|
|
|
namespace webrtc {
|
|
|
|
TextureVideoFrame::TextureVideoFrame(NativeHandle* handle,
|
|
int width,
|
|
int height,
|
|
uint32_t timestamp,
|
|
int64_t render_time_ms)
|
|
: I420VideoFrame(
|
|
new rtc::RefCountedObject<TextureBuffer>(handle, width, height),
|
|
timestamp,
|
|
render_time_ms,
|
|
kVideoRotation_0) {
|
|
}
|
|
|
|
} // namespace webrtc
|