8e7eee0351
Reason for revert: This change appears to break ulpfec, with severe regressions, e.g., for webrtc_perf_test FullStackTest.ForemanCifPlr5Ulpfec Original issue's description: > Reland of Use RtxReceiveStream. (patchset #1 id:1 of https://codereview.webrtc.org/3010983002/ ) > > Reason for revert: > Intend to fix perf failures and reland. > > Original issue's description: > > Revert of Use RtxReceiveStream. (patchset #5 id:80001 of https://codereview.webrtc.org/3008773002/ ) > > > > Reason for revert: > > A few perf tests broken, including > > > > RampUpTest.UpDownUpAbsSendTimeSimulcastRedRtx > > RampUpTest.UpDownUpTransportSequenceNumberRtx > > RampUpTest.UpDownUpTransportSequenceNumberPacketLoss > > > > > > Original issue's description: > > > Use RtxReceiveStream. > > > > > > This also has the beneficial side-effect that when a media stream > > > which is protected by FlexFEC receives an RTX retransmission, the > > > retransmitted media packet is passed into the FlexFEC machinery, > > > which should improve its ability to recover packets via FEC. > > > > > > BUG=webrtc:7135 > > > > > > Review-Url: https://codereview.webrtc.org/3008773002 > > > Cr-Commit-Position: refs/heads/master@{#19649} > > > Committed:5c0f6c62ea> > > > TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:7135 > > > > Review-Url: https://codereview.webrtc.org/3010983002 > > Cr-Commit-Position: refs/heads/master@{#19653} > > Committed:3c39c0137a> > TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > BUG=webrtc:7135 > > Review-Url: https://codereview.webrtc.org/3006063002 > Cr-Commit-Position: refs/heads/master@{#19715} > Committed:35713eaf56TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/3007303002 Cr-Commit-Position: refs/heads/master@{#19744}
43 lines
1.4 KiB
C++
43 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_CALL_RTX_RECEIVE_STREAM_H_
|
|
#define WEBRTC_CALL_RTX_RECEIVE_STREAM_H_
|
|
|
|
#include <map>
|
|
|
|
#include "webrtc/call/rtp_packet_sink_interface.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// This class is responsible for RTX decapsulation. The resulting media packets
|
|
// are passed on to a sink representing the associated media stream.
|
|
class RtxReceiveStream : public RtpPacketSinkInterface {
|
|
public:
|
|
RtxReceiveStream(RtpPacketSinkInterface* media_sink,
|
|
std::map<int, int> associated_payload_types,
|
|
uint32_t media_ssrc);
|
|
~RtxReceiveStream() override;
|
|
// RtpPacketSinkInterface.
|
|
void OnRtpPacket(const RtpPacketReceived& packet) override;
|
|
|
|
private:
|
|
RtpPacketSinkInterface* const media_sink_;
|
|
// Map from rtx payload type -> media payload type.
|
|
const std::map<int, int> associated_payload_types_;
|
|
// TODO(nisse): Ultimately, the media receive stream shouldn't care about the
|
|
// ssrc, and we should delete this.
|
|
const uint32_t media_ssrc_;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_CALL_RTX_RECEIVE_STREAM_H_
|