Reason for revert:
It causes a Chromium build error:
ERROR at //third_party/webrtc/test/BUILD.gn:113:5: Can't load input file.
"//third_party/gflags",
Original issue's description:
> Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ )
>
> Reason for revert:
> Try to fix the webrtc/test/fuzzers issue and reland this CL because it
> contains lots of fixes for our BUILD.gn files.
>
> Original issue's description:
> > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ )
> >
> > Reason for revert:
> > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6).
> >
> > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer.
> >
> > Original issue's description:
> > > Enable GN check for webrtc/base
> > >
> > > It's not possible to enable it for the rtc_base_approved
> > > target but since a larger refactoring is ongoing for webrtc/base
> > > this CL doesn't attempt to fix that.
> > >
> > > Changes made:
> > > * Move webrtc/system_wrappers/include/stringize_macros.h into
> > > webrtc/base:rtc_base_approved_unittests (and corresponding
> > > unit test to rtc_base_approved_unittests).
> > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target.
> > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into
> > > webrtc/base.
> > > * Remove unused use include of webrtc/base/fileutils.h in
> > > webrtc/base/pathutils.cc
> > >
> > > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > > NOTRY=True
> > >
> > > Review-Url: https://codereview.webrtc.org/2717083002
> > > Cr-Commit-Position: refs/heads/master@{#17766}
> > > Committed: ed754e71ae
> >
> > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2838683002
> > Cr-Commit-Position: refs/heads/master@{#17849}
> > Committed: 11ed366c48
>
> TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828, webrtc:3806, webrtc:7480
>
> Review-Url: https://codereview.webrtc.org/2840453004
> Cr-Commit-Position: refs/heads/master@{#17876}
> Committed: 7054085e59
TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828, webrtc:3806, webrtc:7480
Review-Url: https://codereview.webrtc.org/2846483002
Cr-Commit-Position: refs/heads/master@{#17877}
58 lines
1.9 KiB
C++
58 lines
1.9 KiB
C++
/*
|
|
* Copyright 2016 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_LOCATION_H_
|
|
#define WEBRTC_BASE_LOCATION_H_
|
|
|
|
#include <string>
|
|
|
|
#include "webrtc/system_wrappers/include/stringize_macros.h"
|
|
|
|
namespace rtc {
|
|
|
|
// Location provides basic info where of an object was constructed, or was
|
|
// significantly brought to life.
|
|
// This is a stripped down version of:
|
|
// https://code.google.com/p/chromium/codesearch#chromium/src/base/location.h
|
|
class Location {
|
|
public:
|
|
// Constructor should be called with a long-lived char*, such as __FILE__.
|
|
// It assumes the provided value will persist as a global constant, and it
|
|
// will not make a copy of it.
|
|
//
|
|
// TODO(deadbeef): Tracing is currently limited to 2 arguments, which is
|
|
// why the file name and line number are combined into one argument.
|
|
//
|
|
// Once TracingV2 is available, separate the file name and line number.
|
|
Location(const char* function_name, const char* file_and_line);
|
|
Location();
|
|
Location(const Location& other);
|
|
Location& operator=(const Location& other);
|
|
|
|
const char* function_name() const { return function_name_; }
|
|
const char* file_and_line() const { return file_and_line_; }
|
|
|
|
std::string ToString() const;
|
|
|
|
private:
|
|
const char* function_name_;
|
|
const char* file_and_line_;
|
|
};
|
|
|
|
// Define a macro to record the current source location.
|
|
#define RTC_FROM_HERE RTC_FROM_HERE_WITH_FUNCTION(__FUNCTION__)
|
|
|
|
#define RTC_FROM_HERE_WITH_FUNCTION(function_name) \
|
|
::rtc::Location(function_name, __FILE__ ":" STRINGIZE(__LINE__))
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_LOCATION_H_
|