admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Evan Shrubsole 096ad02c02 Revert "Fix race between enabled() and set_enabled() in VideoTrack." 
This reverts commit 5ffefe9d2d743c66f8a8bcbc5ad9662a3138840a.

Reason for revert: Breaks Chromium Android browser tests on fyi bots.

Original change's description:
> Fix race between enabled() and set_enabled() in VideoTrack.
>
> Along the way I introduced VideoSourceBaseGuarded, which is equivalent
> to VideoSourceBase except that it applies thread checks. I found that
> it's easy to use VideoSourceBase incorrectly and in fact there appear
> to be tests that do this.
>
> I made the source object const in VideoTrack, as it already was in
> AudioTrack, and that allowed for making the GetSource() accessors
> bypass the proxy thread hop and give the caller direct access.
>
> Bug: webrtc:12773, b/188139639, webrtc:12780
> Change-Id: I022175c4239a1306ef54059c131d81411d5124fe
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219160
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Andrey Logvin <landrey@webrtc.org>
> Commit-Queue: Tommi <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#34096}

TBR=mbonadei@webrtc.org,tommi@webrtc.org,landrey@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I16323d459c76eb6a87cc602a0048f6ee01c81626
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12773
Bug: b/188139639
Bug: webrtc:12780
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219637
Reviewed-by: Evan Shrubsole <eshr@google.com>
Commit-Queue: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/master@{#34101}
2021-05-24 14:06:19 +00:00
..
g3doc
add dtls docs
2021-05-12 21:16:10 +00:00
scenario_tests
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
test
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
audio_rtp_receiver.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
audio_rtp_receiver.h
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
audio_track.cc
Revert "Fix race between enabled() and set_enabled() in VideoTrack."
2021-05-24 14:06:19 +00:00
audio_track.h
Revert "Fix race between enabled() and set_enabled() in VideoTrack."
2021-05-24 14:06:19 +00:00
BUILD.gn
Enable Chromium to stop including api/proxy.h indirectly.
2021-05-21 09:35:35 +00:00
channel_interface.h
Move header negotiation state to transceivers.
2021-05-04 13:52:35 +00:00
channel_manager_unittest.cc
Add thread accessors to Call.
2021-04-19 15:59:20 +00:00
channel_manager.cc
Remove RTP data implementation
2021-04-16 13:10:54 +00:00
channel_manager.h
Remove more mentions of RTP datachannels
2021-04-21 10:16:43 +00:00
channel_unittest.cc
Remove lock from MediaChannel
2021-05-07 18:01:54 +00:00
channel.cc
Remove lock from MediaChannel
2021-05-07 18:01:54 +00:00
channel.h
Remove lock from MediaChannel
2021-05-07 18:01:54 +00:00
connection_context.cc
Simplify reference counting implementation of PendingTaskSafetyFlag.
2021-04-21 07:04:01 +00:00
connection_context.h
Simplify reference counting implementation of PendingTaskSafetyFlag.
2021-04-21 07:04:01 +00:00
data_channel_controller.cc
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
data_channel_controller.h
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
data_channel_integrationtest.cc
Remove GTEST_ALLOW_UNINSTANTIATED in datachannel tests
2021-05-21 20:50:48 +00:00
data_channel_unittest.cc
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
data_channel_utils.cc
Remove DataChannelType and deprecated option disable_sctp_data_channels
2021-04-19 19:32:23 +00:00
data_channel_utils.h
Remove DataChannelType and deprecated option disable_sctp_data_channels
2021-04-19 19:32:23 +00:00
DEPS
…
dtls_srtp_transport_unittest.cc
Refactor ssl_stream_adapter API to show object ownership
2020-03-21 18:53:46 +00:00
dtls_srtp_transport.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
dtls_srtp_transport.h
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
dtls_transport_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
dtls_transport.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
dtls_transport.h
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
dtmf_sender_unittest.cc
Make RefCountedObject require overriding virtual methods
2021-04-26 11:05:19 +00:00
dtmf_sender.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
dtmf_sender.h
Replace AsyncInvoker with PostDelayedTask, in DtmfSender
2021-03-18 10:21:00 +00:00
external_hmac.cc
…
external_hmac.h
…
ice_server_parsing_unittest.cc
Add create function for PeerConnection that can return an error.
2020-11-27 11:08:10 +00:00
ice_server_parsing.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
ice_server_parsing.h
…
ice_transport_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
ice_transport.cc
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
ice_transport.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
jitter_buffer_delay_unittest.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
jitter_buffer_delay.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
jitter_buffer_delay.h
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
jsep_ice_candidate.cc
Make the JsepSessionDesription clone() method copy candidates.
2021-01-05 12:55:24 +00:00
jsep_session_description_unittest.cc
Make the JsepSessionDesription clone() method copy candidates.
2021-01-05 12:55:24 +00:00
jsep_session_description.cc
Make the JsepSessionDesription clone() method copy candidates.
2021-01-05 12:55:24 +00:00
jsep_transport_controller_unittest.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
jsep_transport_controller.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
jsep_transport_controller.h
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
jsep_transport_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
jsep_transport.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
jsep_transport.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
local_audio_source_unittest.cc
…
local_audio_source.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
local_audio_source.h
…
media_protocol_names.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
media_protocol_names.h
…
media_session_unittest.cc
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
media_session.cc
move removal of CN codecs to a later stage
2021-05-12 10:10:05 +00:00
media_session.h
Remove DataChannelType and deprecated option disable_sctp_data_channels
2021-04-19 19:32:23 +00:00
media_stream_observer.cc
…
media_stream_observer.h
…
media_stream_unittest.cc
In pc/ replace mock macros with unified MOCK_METHOD macro
2020-05-18 17:06:25 +00:00
media_stream.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
media_stream.h
Avoid proxy thread hops for reading const properties.
2020-09-10 13:11:44 +00:00
OWNERS
Adding deadbeef back to OWNERS files
2020-02-25 14:45:04 +00:00
peer_connection_adaptation_integrationtest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
peer_connection_bundle_unittest.cc
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
peer_connection_crypto_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
peer_connection_data_channel_unittest.cc
Remove DataChannelType and deprecated option disable_sctp_data_channels
2021-04-19 19:32:23 +00:00
peer_connection_end_to_end_unittest.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
peer_connection_factory_unittest.cc
…
peer_connection_factory.cc
Add test for many non-dropped packets in unreliable mode.
2021-05-19 17:30:46 +00:00
peer_connection_factory.h
Deprecate PeerConnectionFactory::CreatePeerConnection
2021-05-10 08:47:48 +00:00
peer_connection_header_extension_unittest.cc
Revert "Define cricket::MediaType in terms of webrtc::MediaType"
2021-05-12 17:06:58 +00:00
peer_connection_histogram_unittest.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
peer_connection_ice_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
peer_connection_integrationtest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
peer_connection_interface_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
peer_connection_internal.h
Fix unsafe variable access in RTCStatsCollector
2021-04-19 16:22:23 +00:00
peer_connection_jsep_unittest.cc
Remove enable_rtp_data_channel
2021-04-15 10:20:00 +00:00
peer_connection_media_unittest.cc
peerconnection: add test for createOffer({voiceActivityDetection: true})
2021-05-18 09:10:27 +00:00
peer_connection_message_handler.cc
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
peer_connection_message_handler.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
peer_connection_rampup_tests.cc
Deprecate PeerConnectionFactory::CreatePeerConnection
2021-05-10 08:47:48 +00:00
peer_connection_rtp_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
peer_connection_signaling_unittest.cc
fix payload type collision handling for [35,65]
2021-05-11 07:54:14 +00:00
peer_connection_simulcast_unittest.cc
simulcast: Limit audio transceivers to single stream
2021-04-30 18:55:47 +00:00
peer_connection_wrapper.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
peer_connection_wrapper.h
…
peer_connection.cc
simulcast: Limit audio transceivers to single stream
2021-04-30 18:55:47 +00:00
peer_connection.h
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
proxy_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
remote_audio_source.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
remote_audio_source.h
[Unified Plan] Don't end audio tracks when SSRC changes.
2021-04-08 06:39:22 +00:00
rtc_stats_collector_unittest.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
rtc_stats_collector.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
rtc_stats_collector.h
Remove virtual inheritance from RTCStatsCollector
2021-04-23 08:40:35 +00:00
rtc_stats_integrationtest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
rtc_stats_traversal_unittest.cc
…
rtc_stats_traversal.cc
Add RTCRemoteOutboundRtpStreamStats for audio streams
2021-03-23 18:44:12 +00:00
rtc_stats_traversal.h
…
rtcp_mux_filter_unittest.cc
…
rtcp_mux_filter.cc
…
rtcp_mux_filter.h
…
rtp_media_utils_unittest.cc
…
rtp_media_utils.cc
Reland "Implement transceiver.stop()"
2020-08-11 10:46:23 +00:00
rtp_media_utils.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_parameters_conversion_unittest.cc
Delete obsolete unused rtp header extension conversion
2020-01-09 09:28:07 +00:00
rtp_parameters_conversion.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_parameters_conversion.h
Delete obsolete unused rtp header extension conversion
2020-01-09 09:28:07 +00:00
rtp_receiver_proxy.h
Enable Chromium to stop including api/proxy.h indirectly.
2021-05-21 09:35:35 +00:00
rtp_receiver.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
rtp_receiver.h
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
rtp_sender_proxy.h
Enable Chromium to stop including api/proxy.h indirectly.
2021-05-21 09:35:35 +00:00
rtp_sender_receiver_unittest.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
rtp_sender.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
rtp_sender.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_transceiver_unittest.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
rtp_transceiver.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
rtp_transceiver.h
Enable Chromium to stop including api/proxy.h indirectly.
2021-05-21 09:35:35 +00:00
rtp_transmission_manager.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
rtp_transmission_manager.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
rtp_transport_internal.h
…
rtp_transport_unittest.cc
Extend NetworkRoute with more info about local/remote endpoints
2020-03-20 16:55:38 +00:00
rtp_transport.cc
Store RtpPacketReceived::arrival_time as Timestamp.
2021-05-05 16:22:33 +00:00
rtp_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_data_channel_transport.cc
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
sctp_data_channel_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_data_channel.cc
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
sctp_data_channel.h
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
sctp_transport_unittest.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
sctp_transport.cc
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
sctp_transport.h
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
sctp_utils_unittest.cc
Use rtc::CopyOnWriteBuffer::MutableData through webrtc
2021-01-11 11:31:33 +00:00
sctp_utils.cc
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
sctp_utils.h
datachannel: Merge SendDataParams and DMT types with webrtc equivalent
2021-05-10 10:31:48 +00:00
sdp_offer_answer.cc
Remove check following SetChannel.
2021-05-17 17:49:01 +00:00
sdp_offer_answer.h
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
sdp_serializer_unittest.cc
…
sdp_serializer.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sdp_serializer.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sdp_state_provider.h
Break circular dependency on WebRtcSessionDescriptionFactory
2020-10-26 10:22:46 +00:00
sdp_utils.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sdp_utils.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
session_description_unittest.cc
Remove RTP data implementation
2021-04-16 13:10:54 +00:00
session_description.cc
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
session_description.h
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
simulcast_description.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
simulcast_description.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
srtp_filter_unittest.cc
…
srtp_filter.cc
srtp: compare key length to srtp policy key length
2021-04-12 07:57:03 +00:00
srtp_filter.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
srtp_session_unittest.cc
Remove unused critical section includes.
2020-07-16 13:52:28 +00:00
srtp_session.cc
srtp: compare key length to srtp policy key length
2021-04-12 07:57:03 +00:00
srtp_session.h
srtp: document rationale for srtp overhead calculation
2021-03-08 08:50:09 +00:00
srtp_transport_unittest.cc
…
srtp_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
srtp_transport.h
…
stats_collector_interface.h
Separate PeerConnection's self-message functions to a new file
2020-10-05 12:41:23 +00:00
stats_collector_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
stats_collector.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
stats_collector.h
Fix unsafe variable access in RTCStatsCollector
2021-04-19 16:22:23 +00:00
stream_collection.h
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
track_media_info_map_unittest.cc
Revert "Fix race between enabled() and set_enabled() in VideoTrack."
2021-05-24 14:06:19 +00:00
track_media_info_map.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
track_media_info_map.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
transceiver_list.cc
Add threading assertions to TransceiverList
2021-04-20 06:44:40 +00:00
transceiver_list.h
Add threading assertions to TransceiverList
2021-04-20 06:44:40 +00:00
transport_stats.cc
…
transport_stats.h
Remove cricket::DtlsTransportState.
2021-05-21 21:45:29 +00:00
usage_pattern.cc
Move the PeerConnection's usage pattern concept to its own file.
2020-10-09 08:29:45 +00:00
usage_pattern.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
used_ids_unittest.cc
…
used_ids.h
fix payload type collision handling for [35,65]
2021-05-11 07:54:14 +00:00
video_rtp_receiver_unittest.cc
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
video_rtp_receiver.cc
Revert "Fix race between enabled() and set_enabled() in VideoTrack."
2021-05-24 14:06:19 +00:00
video_rtp_receiver.h
VideoRtpReceiver & AudioRtpReceiver threading fixes.
2021-05-17 14:37:55 +00:00
video_rtp_track_source_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
video_rtp_track_source.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
video_rtp_track_source.h
Delete rtc::Callback0 and friends.
2021-02-16 12:41:35 +00:00
video_track_source.cc
Revert "Fix race between enabled() and set_enabled() in VideoTrack."
2021-05-24 14:06:19 +00:00
video_track_source.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
video_track_unittest.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
video_track.cc
Revert "Fix race between enabled() and set_enabled() in VideoTrack."
2021-05-24 14:06:19 +00:00
video_track.h
Revert "Fix race between enabled() and set_enabled() in VideoTrack."
2021-05-24 14:06:19 +00:00
webrtc_sdp_unittest.cc
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
webrtc_sdp.cc
[Unified Plan] Support multiple BUNDLE groups.
2021-04-27 05:53:37 +00:00
webrtc_sdp.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
webrtc_session_description_factory.cc
Replace more instances of rtc::RefCountedObject with make_ref_counted.
2021-04-27 17:01:59 +00:00
webrtc_session_description_factory.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00