In https://chromium-review.googlesource.com/1650265 attributes like minSdkVersion were moved from AndroidManifest.xml to GN files. For WebRTC there were a few problems with that. * We don't want to suppress UsesMinSdkAttributes lint but now there are these "invalid" manifest files that we can't exclude or discern. So disable this lint error. https://chromium-review.googlesource.com/c/chromium/src/+/1650265/14/build/android/AndroidManifest.xml * We should specify the versions in GN files, so I did that here (by exactly copying the versions that are already in the targets' corresponding XML files), but we never want to get rid of them in the XML files. For now this information will just be duplicated (without any synchronicity check!) so there should be followup to this. Change log:6ae0f0cd4c..bf62d746a4Full diff:6ae0f0cd4c..bf62d746a4Changed dependencies * src/base:9e5e9332df..e5a1d1f652* src/build:5a031748ec..2ef566e990* src/buildtools:6ae683be2f..6f3775ad6e* src/buildtools/linux64: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/buildtools/mac: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/buildtools/win: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 * src/ios:2f5c817266..7f1a97d593* src/testing:1d4247de57..b1b36ff0d4* src/third_party:6f7cbf7c46..42e96c4074* src/third_party/android_sdk/public: ki7EDQRAiZAUYlnTWR1XmI6cJTk65fJ-DNZUU1zrtS8C..xhyuoquVvBTcJelgRjMKZeoBVSQRjB7pLVJPt5C9saIC * src/third_party/android_sdk/public: iIwhhDox5E-mHgwUhCz8JACWQCpUjdqt5KTY9VLugKQC..ppQ4TnqDvBHQ3lXx5KPq97egzF5X2FFyOrVHkGmiTMQC * src/third_party/android_sdk/public: 4Y2Cb2LGzoc-qt-oIUIlhySotJaKeE3ELFedSVe6Uk8C..MSnxgXN7IurL-MQs1RrTkSFSb8Xd1UtZjLArI8Ty1FgC * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ed9fcf3f70..9e5dbd8b46 * src/tools:f58f33bca1..a9a4b8fc7bDEPS diff:6ae0f0cd4c..bf62d746a4/DEPS No update to Clang. Bug: chromium:891996 Change-Id: I773d6fa90e8083d934c84eecc1cb9d7d4496eca0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142235 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28311}
62 lines
2.7 KiB
XML
62 lines
2.7 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<lint>
|
|
<!-- These lint settings is for the Android linter that gets run by
|
|
lint_action.gypi on compile of WebRTC java code. All WebRTC java code
|
|
should lint cleanly for the issues below. -->
|
|
<!-- TODO(phoglund): make work with suppress.py or remove printout referring
|
|
to suppress.py. -->
|
|
|
|
<issue id="UseSparseArrays" severity="ignore"/>
|
|
|
|
<issue id="Registered" severity="ignore"/>
|
|
<issue id="MissingPermission" severity="ignore"/>
|
|
<issue id="ApplySharedPref" severity="ignore"/>
|
|
<issue id="UnusedResources" severity="ignore"/>
|
|
<issue id="IconColors" severity="ignore"/>
|
|
<issue id="IconDipSize" severity="ignore"/>
|
|
<issue id="IconDuplicatesConfig" severity="ignore"/>
|
|
<issue id="RelativeOverlap" severity="ignore"/>
|
|
<issue id="RtlCompat" severity="ignore"/>
|
|
<issue id="IconMissingDensityFolder" severity="ignore"/>
|
|
<issue id="OldTargetApi" severity="ignore"/>
|
|
|
|
<issue id="GoogleAppIndexingWarning" severity="ignore"/>
|
|
<issue id="MissingRegistered" severity="ignore"/>
|
|
<issue id="LintError">
|
|
<!-- We no longer supply class files to lint. -->
|
|
<ignore regexp="No `.class` files were found in project"/>
|
|
</issue>
|
|
<!-- These are just from the dummy AndroidManifest.xml we use for linting.
|
|
It's in the same directory as this file. -->
|
|
<issue id="MissingApplicationIcon" severity="ignore"/>
|
|
<issue id="AllowBackup" severity="ignore"/>
|
|
<issue id="MissingVersion" severity="ignore"/>
|
|
|
|
<!-- Ignore all lint errors in Chromium code. -->
|
|
<issue id="all">
|
|
<ignore path="**/org/chromium/**/*.java" />
|
|
</issue>
|
|
|
|
<issue id="UsesMinSdkAttributes">
|
|
<!-- TODO(oprypin): find a way to disable this warning just for Chromium's
|
|
code, not globally. Due to https://cs.chromium.org/lint_manifest_path
|
|
it is impossible to discern paths of AndroidManifest.xml files.-->
|
|
<ignore path="AndroidManifest.xml" />
|
|
</issue>
|
|
|
|
<issue id="NewApi">
|
|
<!-- This is rewritten by desugar after lint runs. -->
|
|
<ignore regexp="Call requires API level 19.*`java.util.Objects#requireNonNull`"/>
|
|
<!-- AutoCloseable has been available since API 15, just hidden. -->
|
|
<ignore regexp="Class requires API level 19.*java.lang.AutoCloseable"/>
|
|
<ignore regexp="Call requires API level 19.*java.lang.AutoCloseable#close"/>
|
|
<!-- We support try-with-resources via desugar. -->
|
|
<ignore regexp="Try-with-resources requires API level 19"/>
|
|
<ignore regexp="Call requires API level 19.*`java.lang.Throwable#addSuppressed`"/>
|
|
<!-- We support new language features via desugar. -->
|
|
<ignore regexp="Default method requires API level 24"/>
|
|
<ignore regexp="Static interface method requires API level 24"/>
|
|
</issue>
|
|
|
|
</lint>
|