3f0d8e46a8
This reverts commit d6bb18479f4d9e258ae3e05427c101fb9e635373. Reason for revert: Breaks Chromium Roll. Example: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/382446 Roll: https://chromium-review.googlesource.com/c/chromium/src/+/1859941 Original change's description: > Delete methods EncodedImage::Allocate and EncodedImageBufferInterface::Realloc > > Bug: webrtc:9378 > Change-Id: I3b03656769623647fcbb4f9125a3e920b7650fe9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155961 > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29458} TBR=ilnik@webrtc.org,nisse@webrtc.org,philipel@webrtc.org Change-Id: I7209c5ae2be2d512572210cf08a4751ee2ee5bc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9378 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157040 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29473}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.