2c41cbae37
This reverts commit fb0dca6c055cbf9e43af665d3c437eba6f43372e. Reason for revert: Speculative revert due to failing stats test in chromium. Possibly because the chromium test expected the metrics to not be supported, and now they are. Reverting just to unblock the webrtc roll into chromium. Original change's description: > Wire up non-sender RTT for audio, and implement related standardized stats. > > The implemented stats are: > - https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats-roundtriptime > - https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats-totalroundtriptime > - https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats-roundtriptimemeasurements > > Bug: webrtc:12951, webrtc:12714 > Change-Id: Ia362d5c4b0456140e32da79d40edc06ab9ce2a2c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226956 > Commit-Queue: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#34861} # Not skipping CQ checks because original CL landed > 1 day ago. TBR=hta,hbos,minyue Bug: webrtc:12951, webrtc:12714 Change-Id: If07ad63286eea9cdde88271e61cc28f4b268b290 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231001 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Olga Sharonova <olka@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34897}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.