871e144132
This reverts commit 12e5d392cc8fc0ba7a04587c190daa4232e412bb. Reason for revert: Partial Capture API is not needed, according to new info from the Chrome team. Original change's description: > Reland "Partial frame capture API part 1" > > Reland with fixes to undefined behavior. > > Define new optional struct in VideoFrame to signal that the frame is a > changed part of a whole picture and add a flag to signal that partial > update may be issued by the VideoFrame source. > > Also, fix too strict assumptions in FrameBuffers PasteFrom methods. > Also, add ability to set a new buffer in video frame. > > Original Reviewed-on: https://webrtc-review.googlesource.com/c/120405 > > Bug: webrtc:10152 > Change-Id: I85790dfc7cec2f23abfe9d6cd18dc76a0c343bc0 > Reviewed-on: https://webrtc-review.googlesource.com/c/120780 > Reviewed-by: Niels Moller <nisse@webrtc.org> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26493} TBR=ilnik@webrtc.org,nisse@webrtc.org,sprang@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:10152 Change-Id: I1c1dd51a8b5a09f743f212336beb01447f60f26e Reviewed-on: https://webrtc-review.googlesource.com/c/122092 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26638}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.