1256d9bcac
This change avoids inadvertent capture of certain system windows (e.g. the Start menu, other taskbar menus, and notification toasts) when capturing a specific window on Windows. It stops using EnumWindows for detection of overlapping windows, because this API excludes these system windows from its enumeration. Using FindWindowEx instead enumerates these windows. The enumeration logic is refactored somewhat because a callback is no longer necessary. Bug: webrtc:10835 Change-Id: I1cccd44d6ef07f13a68e8daf2d2573d422001201 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161153 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#30022}
61 lines
2.2 KiB
C++
61 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/desktop_capture/win/selected_window_context.h"
|
|
|
|
namespace webrtc {
|
|
|
|
SelectedWindowContext::SelectedWindowContext(
|
|
HWND selected_window,
|
|
DesktopRect selected_window_rect,
|
|
WindowCaptureHelperWin* window_capture_helper)
|
|
: selected_window_(selected_window),
|
|
selected_window_rect_(selected_window_rect),
|
|
window_capture_helper_(window_capture_helper) {
|
|
selected_window_thread_id_ =
|
|
GetWindowThreadProcessId(selected_window, &selected_window_process_id_);
|
|
}
|
|
|
|
bool SelectedWindowContext::IsSelectedWindowValid() const {
|
|
return selected_window_thread_id_ != 0;
|
|
}
|
|
|
|
bool SelectedWindowContext::IsWindowOwnedBySelectedWindow(HWND hwnd) const {
|
|
// This check works for drop-down menus & dialog pop-up windows. It doesn't
|
|
// work for context menus or tooltips, which are handled differently below.
|
|
if (GetAncestor(hwnd, GA_ROOTOWNER) == selected_window_) {
|
|
return true;
|
|
}
|
|
|
|
// Some pop-up windows aren't owned (e.g. context menus, tooltips); treat
|
|
// windows that belong to the same thread as owned.
|
|
DWORD enumerated_window_process_id = 0;
|
|
DWORD enumerated_window_thread_id =
|
|
GetWindowThreadProcessId(hwnd, &enumerated_window_process_id);
|
|
return enumerated_window_thread_id != 0 &&
|
|
enumerated_window_process_id == selected_window_process_id_ &&
|
|
enumerated_window_thread_id == selected_window_thread_id_;
|
|
}
|
|
|
|
bool SelectedWindowContext::IsWindowOverlappingSelectedWindow(HWND hwnd) const {
|
|
return window_capture_helper_->AreWindowsOverlapping(hwnd, selected_window_,
|
|
selected_window_rect_);
|
|
}
|
|
|
|
HWND SelectedWindowContext::selected_window() const {
|
|
return selected_window_;
|
|
}
|
|
|
|
WindowCaptureHelperWin* SelectedWindowContext::window_capture_helper() const {
|
|
return window_capture_helper_;
|
|
}
|
|
|
|
} // namespace webrtc
|