* Better param names * Avoid using negative values for (bogus) placeholder channel counts (mostly in tests). Since channels will be changing to size_t, negative values will be illegal; it's sufficient to use 0 in these cases. * Use arraysize() * Use size_t for counting frames, samples, blocks, buffers, and bytes -- most of these are already size_t in most places, this just fixes some stragglers * reinterpret_cast<int64_t>(void*) is not necessarily safe; use uintptr_t instead * Remove unnecessary code, e.g. dead code, needlessly long/repetitive code, or function overrides that exactly match the base definition * Fix indenting * Use uint32_t for timestamps (matching how it's already a uint32_t in most places) * Spelling * RTC_CHECK_EQ(expected, actual) * Rewrap * Use .empty() * Be more pedantic about matching int/int32_t/ * Remove pointless consts on input parameters to functions * Add missing sanity checks All this was found in the course of constructing https://codereview.webrtc.org/1316523002/ , and is being landed separately first. BUG=none TEST=none Review URL: https://codereview.webrtc.org/1534193008 Cr-Commit-Position: refs/heads/master@{#11191}
87 lines
2.1 KiB
C++
87 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_SYSTEM_WRAPPERS_INCLUDE_ALIGNED_ARRAY_
|
|
#define WEBRTC_SYSTEM_WRAPPERS_INCLUDE_ALIGNED_ARRAY_
|
|
|
|
#include "webrtc/base/checks.h"
|
|
#include "webrtc/system_wrappers/include/aligned_malloc.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Wrapper class for aligned arrays. Every row (and the first dimension) are
|
|
// aligned to the given byte alignment.
|
|
template<typename T> class AlignedArray {
|
|
public:
|
|
AlignedArray(int rows, size_t cols, size_t alignment)
|
|
: rows_(rows),
|
|
cols_(cols) {
|
|
RTC_CHECK_GT(alignment, 0u);
|
|
head_row_ = static_cast<T**>(AlignedMalloc(rows_ * sizeof(*head_row_),
|
|
alignment));
|
|
for (int i = 0; i < rows_; ++i) {
|
|
head_row_[i] = static_cast<T*>(AlignedMalloc(cols_ * sizeof(**head_row_),
|
|
alignment));
|
|
}
|
|
}
|
|
|
|
~AlignedArray() {
|
|
for (int i = 0; i < rows_; ++i) {
|
|
AlignedFree(head_row_[i]);
|
|
}
|
|
AlignedFree(head_row_);
|
|
}
|
|
|
|
T* const* Array() {
|
|
return head_row_;
|
|
}
|
|
|
|
const T* const* Array() const {
|
|
return head_row_;
|
|
}
|
|
|
|
T* Row(int row) {
|
|
RTC_CHECK_LE(row, rows_);
|
|
return head_row_[row];
|
|
}
|
|
|
|
const T* Row(int row) const {
|
|
RTC_CHECK_LE(row, rows_);
|
|
return head_row_[row];
|
|
}
|
|
|
|
T& At(int row, size_t col) {
|
|
RTC_CHECK_LE(col, cols_);
|
|
return Row(row)[col];
|
|
}
|
|
|
|
const T& At(int row, size_t col) const {
|
|
RTC_CHECK_LE(col, cols_);
|
|
return Row(row)[col];
|
|
}
|
|
|
|
int rows() const {
|
|
return rows_;
|
|
}
|
|
|
|
size_t cols() const {
|
|
return cols_;
|
|
}
|
|
|
|
private:
|
|
int rows_;
|
|
size_t cols_;
|
|
T** head_row_;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_SYSTEM_WRAPPERS_INCLUDE_ALIGNED_ARRAY_
|