6866da1822
This reverts commit 51a70c0d6f8c94985f5e592813d7c0c6b3140c86. Reason for revert: Breaks downstream project test. Original change's description: > Add more accurate support for changing capacity in SimulatedNetwork > > NetworkBehaviorInterface::RegisterDeliveryTimeChangedCallback > adds support for a network behaviour to reschedule next time DequeueDeliverablePackets should be invoked. > > SimulatedNetwork::SetConfig(const BuiltInNetworkBehaviorConfig& config, > Timestamp config_update_time) > adds possibility to change the configuration at config_update_time. Delivery time of a packet currently in the narrow section, will depend on the link capacity before and after the update. > > Bug: webrtc:14525 > Change-Id: I271251992d05c68f9160bb81811ea8f2efe9c921 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349461 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42243} Bug: webrtc:14525 Change-Id: Iace13b1b4ef21005c9668ff27f6d1ec8f3212baf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349923 Owners-Override: Per Kjellander <perkj@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Per Kjellander <perkj@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42245}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particular challenging as it is designed to be used in other code bases and thus needs to be updated independetly from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve existent struct in api, prefer first to convert it into a class.