2a8779763a
TransmitMixer's functionality is moved into the AudioTransportProxy
owned by AudioState. This removes the need for an AudioTransport
implementation in VoEBaseImpl, which means that the proxy is no longer
a proxy, hence AudioTransportProxy is renamed to AudioTransportImpl.
In the short term, AudioState needs to know which AudioDeviceModule is
used, so it is added in AudioState::Config. AudioTransportImpl needs
to know which AudioSendStream:s are currently enabled to send, so
AudioState maintains a map of them, which is reduced into a simple
vector for AudioTransportImpl.
To encode and transmit audio,
AudioSendStream::OnAudioData(std::unique_ptr<AudioFrame> audio_frame)
is introduced, which is used in both the Chromium and standalone use
cases. This removes the need for two different instances of
voe::Channel::ProcessAndEncodeAudio(), so there is now only one,
taking an AudioFrame as argument. Callers need to allocate their own
AudioFrame:s, which is wasteful but not a regression since this was
already happening in the voe::Channel functions.
Most of the logic changed resides in
AudioTransportImpl::RecordedDataIsAvailable(), where two strange
things were found:
1. The clock drift parameter was ineffective since
apm->echo_cancellation()->enable_drift_compensation(false) is
called during initialization.
2. The output parameter 'new_mic_volume' was never set - instead it
was returned as a result, causing the ADM to never update the
analog mic gain
(https://cs.chromium.org/chromium/src/third_party/webrtc/voice_engine/voe_base_impl.cc?q=voe_base_impl.cc&dr&l=100).
Besides this, tests are updated, and some dead code is removed which
was found in the process.
Bug: webrtc:4690, webrtc:8591
Change-Id: I789d5296bf5efb7299a5ee05a4f3ce6abf9124b2
Reviewed-on: https://webrtc-review.googlesource.com/26681
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21301}
52 lines
1.4 KiB
C++
52 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "voice_engine/include/voe_base.h"
|
|
|
|
#include "api/audio_codecs/builtin_audio_decoder_factory.h"
|
|
#include "modules/audio_device/include/fake_audio_device.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class VoEBaseTest : public ::testing::Test {
|
|
protected:
|
|
VoEBaseTest()
|
|
: voe_(VoiceEngine::Create()),
|
|
base_(VoEBase::GetInterface(voe_)) {
|
|
EXPECT_NE(nullptr, base_);
|
|
}
|
|
|
|
~VoEBaseTest() {
|
|
base_->Terminate();
|
|
EXPECT_EQ(1, base_->Release());
|
|
EXPECT_TRUE(VoiceEngine::Delete(voe_));
|
|
}
|
|
|
|
VoiceEngine* voe_;
|
|
VoEBase* base_;
|
|
FakeAudioDeviceModule adm_;
|
|
};
|
|
|
|
TEST_F(VoEBaseTest, InitWithExternalAudioDevice) {
|
|
EXPECT_EQ(0,
|
|
base_->Init(&adm_, nullptr, CreateBuiltinAudioDecoderFactory()));
|
|
}
|
|
|
|
TEST_F(VoEBaseTest, CreateChannelAfterInit) {
|
|
EXPECT_EQ(0,
|
|
base_->Init(&adm_, nullptr, CreateBuiltinAudioDecoderFactory()));
|
|
int channelID = base_->CreateChannel();
|
|
EXPECT_NE(channelID, -1);
|
|
EXPECT_EQ(0, base_->DeleteChannel(channelID));
|
|
}
|
|
|
|
} // namespace webrtc
|