Taylor Brandstetter
239ac8a4e2
Reland "Pass NetworkMonitorFactory through PeerConnectionFactory."
...
This is a reland of 003c9be817817ed0e3aef3f50c78ae5cb31bc0ff
Found some downstream code that relies on
NetworkMonitorFactory::SetFactory, so I'm adding those methods back
temporarily. BasicNetworkManager will fall back to the static factory
if the one passed into PeerConnectionFactory is null.
Original change's description:
> Pass NetworkMonitorFactory through PeerConnectionFactory.
>
> Previously the instance was set through a static method, which was
> really only done because it was difficult to add new
> PeerConnectionFactory construction arguments at the time.
>
> Now that we have PeerConnectionFactoryDependencies it's easy to clean
> this up.
>
> I'm doing this because I plan to add a NetworkMonitor implementation
> for iOS, and don't want to inherit this ugliness.
>
> Bug: webrtc:9883
> Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31815}
TBR=hta@webrtc.org , sakal@webrtc.org
Bug: webrtc:9883
Change-Id: I2e817c423f21936f87532a9694eb9a0a1b70c212
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180722
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31824}
2020-08-01 00:36:27 +00:00
..
2020-03-05 16:29:55 +00:00
2020-07-29 11:27:43 +00:00
2020-04-02 14:04:50 +00:00
2020-04-01 08:15:53 +00:00
2019-04-08 16:58:07 +00:00
2019-01-25 20:29:58 +00:00
2020-07-15 06:54:06 +00:00
2019-01-28 18:56:02 +00:00
2020-06-17 08:41:14 +00:00
2020-06-17 08:41:14 +00:00
2020-06-17 08:41:14 +00:00
2020-06-17 08:41:14 +00:00
2020-07-29 09:57:24 +00:00
2020-07-16 13:52:28 +00:00
2020-03-20 16:55:38 +00:00
2019-07-08 13:45:15 +00:00
2019-06-07 20:14:36 +00:00
2020-07-10 00:03:21 +00:00
2020-07-10 00:03:21 +00:00
2020-07-10 00:03:21 +00:00
2020-07-17 08:28:20 +00:00
2020-07-10 00:03:21 +00:00
2019-01-28 11:17:00 +00:00
2020-03-21 18:53:46 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2020-03-21 18:53:46 +00:00
2020-07-07 18:25:09 +00:00
2020-07-07 18:25:09 +00:00
2020-01-22 20:46:52 +00:00
2020-01-22 20:46:52 +00:00
2020-01-22 20:46:52 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-04-02 10:13:36 +00:00
2019-09-17 15:47:29 +00:00
2019-04-09 09:12:10 +00:00
2019-01-30 16:16:51 +00:00
2019-04-18 19:11:31 +00:00
2019-04-18 19:11:31 +00:00
2019-07-08 13:45:15 +00:00
2019-04-18 19:11:31 +00:00
2019-04-18 19:11:31 +00:00
2019-09-17 15:47:29 +00:00
2019-09-17 15:47:29 +00:00
2019-10-14 12:40:53 +00:00
2020-06-17 08:41:14 +00:00
2020-07-17 08:36:00 +00:00
2020-07-17 08:36:00 +00:00
2020-06-17 08:41:14 +00:00
2020-07-15 06:54:06 +00:00
2020-07-17 09:19:50 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-05-13 18:37:47 +00:00
2019-05-13 18:37:47 +00:00
2020-06-24 10:38:30 +00:00
2020-07-17 08:28:20 +00:00
2020-06-24 10:38:30 +00:00
2019-01-29 02:33:50 +00:00
2019-01-25 20:29:58 +00:00
2019-01-11 17:11:39 +00:00
2020-05-18 17:06:25 +00:00
2019-07-08 13:45:15 +00:00
2019-01-25 20:29:58 +00:00
2020-02-25 14:45:04 +00:00
2020-06-11 14:17:01 +00:00
2019-09-17 15:47:29 +00:00
2020-05-12 14:43:43 +00:00
2020-02-05 23:33:29 +00:00
2019-11-26 18:28:07 +00:00
2019-07-08 13:45:15 +00:00
2020-08-01 00:36:27 +00:00
2020-08-01 00:36:27 +00:00
2020-06-24 10:38:30 +00:00
2019-12-09 13:55:50 +00:00
2020-01-30 23:17:59 +00:00
2020-06-17 08:41:14 +00:00
2020-07-15 07:35:16 +00:00
2020-07-10 00:03:21 +00:00
2020-03-18 21:03:20 +00:00
2020-06-10 10:12:32 +00:00
2019-09-17 15:47:29 +00:00
2019-12-09 13:55:50 +00:00
2020-07-29 11:27:43 +00:00
2019-12-09 13:55:50 +00:00
2020-07-29 11:27:43 +00:00
2019-10-14 12:40:53 +00:00
2020-07-29 11:27:43 +00:00
2020-07-29 11:27:43 +00:00
2020-05-18 17:06:25 +00:00
2020-07-30 08:10:03 +00:00
2020-07-07 18:25:09 +00:00
2020-07-10 11:50:59 +00:00
2020-07-10 11:50:59 +00:00
2020-07-10 00:03:21 +00:00
2020-07-10 11:50:59 +00:00
2019-04-09 17:18:20 +00:00
2020-01-07 17:26:01 +00:00
2019-01-25 20:29:58 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-07-10 00:03:21 +00:00
2020-07-10 00:03:21 +00:00
2019-07-08 13:45:15 +00:00
2020-03-11 11:19:51 +00:00
2019-04-16 12:04:33 +00:00
2020-01-09 09:28:07 +00:00
2020-02-13 10:10:37 +00:00
2020-01-09 09:28:07 +00:00
2019-07-08 13:45:15 +00:00
2019-09-16 21:29:58 +00:00
2020-06-17 08:41:14 +00:00
2020-07-07 18:25:09 +00:00
2020-07-07 18:25:09 +00:00
2020-06-24 10:38:30 +00:00
2020-06-24 10:38:30 +00:00
2020-06-24 10:38:30 +00:00
2019-05-24 23:58:46 +00:00
2020-03-20 16:55:38 +00:00
2019-07-08 13:45:15 +00:00
2019-05-24 23:58:46 +00:00
2019-12-16 14:54:56 +00:00
2019-12-16 14:54:56 +00:00
2020-07-10 00:03:21 +00:00
2020-07-10 00:03:21 +00:00
2019-11-16 14:56:01 +00:00
2020-07-07 18:25:09 +00:00
2020-07-07 18:25:09 +00:00
2020-05-17 10:57:27 +00:00
2020-05-17 10:57:27 +00:00
2019-10-01 12:23:19 +00:00
2019-07-08 13:45:15 +00:00
2019-04-09 21:19:31 +00:00
2019-01-11 17:11:39 +00:00
2019-10-14 12:40:53 +00:00
2019-11-05 09:40:03 +00:00
2019-09-17 15:47:29 +00:00
2020-02-27 14:13:03 +00:00
2020-07-30 21:16:08 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-04-01 11:15:00 +00:00
2020-07-16 13:52:28 +00:00
2020-07-16 13:52:28 +00:00
2020-07-15 20:45:13 +00:00
2020-07-15 20:45:13 +00:00
2019-09-17 15:47:29 +00:00
2020-04-01 11:15:00 +00:00
2019-07-08 13:45:15 +00:00
2020-07-10 00:03:21 +00:00
2020-07-10 00:03:21 +00:00
2019-10-15 10:43:59 +00:00
2019-01-11 17:11:39 +00:00
2020-05-17 17:15:10 +00:00
2020-07-08 10:12:59 +00:00
2019-01-11 17:11:39 +00:00
2019-02-05 15:12:20 +00:00
2019-10-28 11:30:23 +00:00
2019-09-24 08:56:24 +00:00
2019-06-24 08:50:07 +00:00
2020-05-18 17:06:25 +00:00
2020-04-11 12:04:24 +00:00
2020-03-02 08:33:44 +00:00
2020-05-18 17:06:25 +00:00
2020-07-07 18:25:09 +00:00
2020-07-07 18:25:09 +00:00
2019-07-08 13:45:15 +00:00
2020-05-11 12:28:32 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-01-25 20:29:58 +00:00
2020-07-30 21:16:08 +00:00
2020-07-30 21:16:08 +00:00
2020-02-13 10:10:37 +00:00
2019-09-17 15:47:29 +00:00
2020-01-08 14:12:08 +00:00